[
https://issues.apache.org/jira/browse/CASSANDRA-16789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419261#comment-17419261
]
Ekaterina Dimitrova commented on CASSANDRA-16789:
-------------------------------------------------
Thank you [~paulo]. I didn't spend time on this ticket so IMHO it won't be fair
to be marked as a reviewer. I removed myself.
I personally think at this point just adding a note on the ticket is enough.
{quote}We didn't have any intention to claim authorship on this class since
that work would be eventually included in the context of CASSANDRA-15234 so its
authorship was well-known in my view, but I agree it should have been given
proper credit anyway.
{quote}
Exactly, it took me one minute to recognize it and that's why we need to be
careful as not everyone knows the history and have our understanding that
eventually it will be in and it doesn't make any sense to write different code
from scratch. Please, feel free to add also the unit tests as I think they
might prevent regressions as the framework is still not incorporated and things
are still hectic around the units.
Also, I want to encourage you to join the ML discussion. I plan to summarize
the outcome next week so there is still some time if you have any thoughts to
share.
> Add TTL support to nodetool snapshots
> -------------------------------------
>
> Key: CASSANDRA-16789
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16789
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/nodetool
> Reporter: Paulo Motta
> Assignee: Abuli Palagashvili
> Priority: Normal
> Fix For: 4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add new parameter {{--ttl}} to {{nodetool snapshot}} command. This parameter
> can be specified in human readable duration (ie. 30mins, 1h, 300d) and should
> not be lower than 1 minute.
> The expiration date should be added to the snapshot manifest in ISO format.
> A periodic thread should efficiently scan snapshots and automatically clear
> those past expiration date. The periodicity of the scan thread should be 1
> minute by default but be overridable via a system property.
> The command {{nodetool listsnapshots}} should display the expiration date
> when the snapshot contains a TTL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
