[ 
https://issues.apache.org/jira/browse/CASSANDRA-16987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419672#comment-17419672
 ] 

Bowen Song commented on CASSANDRA-16987:
----------------------------------------

[~e.dimitrova] Thank you. I can see the test result is 7 failures (+4) , 960 
skipped (-36). However I don't see how is this change in any way possible to 
have any effect on the failed tests:
{quote}org.apache.cassandra.distributed.upgrade
org.apache.cassandra.net
dtest.scrub_test
dtest-upgrade.upgrade_tests.upgrade_through_versions_test
dtest-novnode.scrub_test{quote}

I clicked open some of these failed tests, and it appears to be something 
totally irrelevant to the changes made in the commit, for example, 
org.apache.cassandra.distributed.upgrade.CompactStorageUpgradeTest.compactStorageUpgradeTest
 failed because java.lang.OutOfMemoryError: GC overhead limit exceeded.

Are these just flaky tests? Were they broken before my change? How do I know if 
any is caused by my change?

> CQLSH shell script will fail on Python 3.10
> -------------------------------------------
>
>                 Key: CASSANDRA-16987
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16987
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/cqlsh
>            Reporter: Bowen Song
>            Assignee: Bowen Song
>            Priority: Normal
>             Fix For: 4.0.x, 4.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The `is_supported_version()` function performs a lexicographical comparison 
> between the Python version number in the format of `MAJOR.MINOR` with `3.6`. 
> This works as expected if the Python version number is between `3.0` and 
> `3.9` (inclusive), but will produce an unexpected result if the Python 
> version number is `3.10` or above.
> Recommended fix is to split the version number into two integers, 
> `$version_major` and `$version_minor` and then compare them to `3` and `6` 
> respectively.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to