[
https://issues.apache.org/jira/browse/CASSANDRA-16983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420398#comment-17420398
]
Stefan Miklosovic edited comment on CASSANDRA-16983 at 9/26/21, 9:52 PM:
-------------------------------------------------------------------------
Hi [~Bowen Song], great patch! The only thing I am kind of lacking are some
tests. I think this can be tested via CQLSH invoked from Java as a tool. Check
the package test/unit/org/apache/cassandra/tools/cqlsh/CqlshTest. There is a
bunch of stuff in ToolRunner related to cqlsh and it is imo just a matter of
putting all the bits together to test what you just implemented.
EDIT: you might also implement this in cassandra-dtest (repo under apache org
in gh) which is written in Python if that is your expertise but I would like to
see this in Java first and if not possible or too hard for you, I guess some
tests in cassandra-dtest might do it too.
was (Author: stefan.miklosovic):
Hi [~Bowen Song], great patch! The only thing I am kind of lacking are some
tests. I think this can be tested via CQLSH invoked from Java as a tool. Check
the package test/unit/org/apache/cassandra/tools/cqlsh/CqlshTest. There is a
bunch of stuff in ToolRunner related to cqlsh and it is imo just a matter of
putting all the bits together to test what you just implemented.
> Separating CQLSH credentials from the cqlshrc file
> --------------------------------------------------
>
> Key: CASSANDRA-16983
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16983
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/cqlsh
> Reporter: Bowen Song
> Assignee: Bowen Song
> Priority: Normal
> Labels: lhf
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the CQLSH tool accepts credentials (username & password) from the
> following 3 places:
> 1. the command line parameter "-p"
> 2. the cqlshrc file
> 3. prompt the user
> This is not ideal.
> Credentials in the command line is a security risk, because it could be see
> by other users on a shared system.
> The cqlshrc file is better, but still not good enough. Because the cqlshrc
> file is a config file, it's often acceptable to have it as a world readable
> file, and share it with other users. It also prevents user from having
> multiple sets of credentials, either for the same Cassandra cluster or
> different clusters.
> To improve the security of CQLSH and make it secure by design, I purpose the
> following changes:
> * Warn the user if a password is giving in the command line, and recommend
> them to use a credential file instead
> * Warn the user if credentials are present in the cqlshrc file and the
> cqlshrc file is not secure (e.g.: world readable or owned by a different user)
> * Deprecate credentials in the cqlshrc, and recommend the user to move them
> to a separate credential file. The aim is to not break anything at the
> moment, but eventually stop accepting credentials from the cqlshrc file.
> * Reject the credentials file if it's not secure, and tell the user how to
> secure it. Optionally, prompt the user for password if it's an interactive
> session. (Think how does OpenSSH handle insecure credential files)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
