[ 
https://issues.apache.org/jira/browse/CASSANDRA-16844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417168#comment-17417168
 ] 

Aleksei Zotov edited comment on CASSANDRA-16844 at 9/27/21, 1:39 PM:
---------------------------------------------------------------------

[~brandon.williams]

I have a question - do we try to have the same functionality for both 
{{nodetool}} commands and virtual tables?

If yes, I feel we need to add this column to 
[SSTableTasksTable.java|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/virtual/SSTableTasksTable.java]
 (CASSANDRA-14457). If you will be adding this column, could you please also 
update documentation and fix a minor bug introduced by CASSANDRA-15759 
({{completion_ratio}} was added to the table, but not mentioned in 
[virtualtables.rst|https://github.com/apache/cassandra/blob/trunk/doc/source/new/virtualtables.rst]).
 If no, I'll raise a separate ticket to fix that documentation issue.

*Update*: Basically then we'll have to add {{compaction_ratio}} here.. I'm not 
sure what is a good way to ensure sync between commands and tables if we really 
looking for that.

 

cc: [~samt] (we have a similar discussion in another ticket)


was (Author: azotcsit):
[~brandon.williams]

I have a question - do we try to have the same functionality for both 
{{nodetool}} commands and virtual tables?

If yes, I feel we need to add this column to 
[SSTableTasksTable.java|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/virtual/SSTableTasksTable.java]
 (CASSANDRA-14457). If you will be adding this column, could you please also 
update documentation and fix a minor bug introduced by CASANDRA-15759 
({{completion_ratio}} was added to the table, but not mentioned in 
[virtualtables.rst|https://github.com/apache/cassandra/blob/trunk/doc/source/new/virtualtables.rst]).
 If no, I'll raise a separate ticket to fix that documentation issue.

*Update*: Basically then we'll have to add {{compaction_ratio}} here.. I'm not 
sure what is a good way to ensure sync between commands and tables if we really 
looking for that.

 

cc: [~samt] (we have a similar discussion in another ticket)

> Add number of sstables in a compaction to compactionstats output
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-16844
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16844
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/nodetool
>            Reporter: Brendan Cicchi
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 4.1
>
>
> It would be helpful to know at a glance how many sstables are involved in any 
> running compactions. While this information can certainly be collected now, a 
> user has to grab it from the debug logs. I think it would be helpful for some 
> use cases to have this information straight from {{nodetool compactionstats}} 
> and then if the actual sstables involved in the compactions are desired, dive 
> into the debug.log for that. I think it would also be good to have this 
> information in the output of {{nodetool compactionhistory}}.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to