[ 
https://issues.apache.org/jira/browse/CASSANDRA-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420806#comment-17420806
 ] 

Stefan Miklosovic edited comment on CASSANDRA-9384 at 9/27/21, 3:06 PM:
------------------------------------------------------------------------

Hi [~djoshi],

I am proposing this branch to be merged for 3.0 (1), there is "approach 1" so 
we fill fail unless a user does check that the number of rounds is at most 30. 
We are upgrading the lib in all branches here and I will apply same patch for 
branch 3.11, 4.0 and trunk.

Please review and give me +1 if you are ok with this. I also slightly changed 
the related test because if I set rounds to 30, that test has not finished in a 
reasonable time so it would be probably killed in Jenkins anyway. My notebook 
was just salting and salting ...

I will create a new ticket for covering the problem I was talking about 
previously - user is created even though the query has time-outed. I just want 
to get rid of this one and not to complicate it too much for now as this is the 
last blocker for CASSANDRA-14612.

[https://github.com/instaclustr/cassandra/commits/CASSANDRA-9384-3.0]
https://app.circleci.com/pipelines/github/instaclustr/cassandra/497/workflows/1b18fb38-9aa8-4ec2-b52e-2f15f64582a0




was (Author: stefan.miklosovic):
Hi [~djoshi],

I am proposing this branch to be merged for 3.0 (1), there is "approach 1" so 
we fill fail unless a user does not check that the number of rounds is at most 
30. We are upgrading the lib in all branches here and I will apply same patch 
for branch 3.11, 4.0 and trunk.

Please review and give me +1 if you are ok with this. I also slightly changed 
the related test because if I set rounds to 30, that test has not finished in a 
reasonable time so it would be probably killed in Jenkins anyway. My notebook 
was just salting and salting ...

I will create a new ticket for covering the problem I was talking about 
previously - user is created even though the query has time-outed. I just want 
to get rid of this one and not to complicate it too much for now as this is the 
last blocker for CASSANDRA-14612.

[https://github.com/instaclustr/cassandra/commits/CASSANDRA-9384-3.0]
https://app.circleci.com/pipelines/github/instaclustr/cassandra/497/workflows/1b18fb38-9aa8-4ec2-b52e-2f15f64582a0



> Update jBCrypt dependency to version 0.4
> ----------------------------------------
>
>                 Key: CASSANDRA-9384
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9384
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sam Tunnicliffe
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> https://bugzilla.mindrot.org/show_bug.cgi?id=2097
> Although the bug tracker lists it as NEW/OPEN, the release notes for 0.4 
> indicate that this is now fixed, so we should update.
> Thanks to [~Bereng] for identifying the issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to