[
https://issues.apache.org/jira/browse/CASSANDRA-16976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422752#comment-17422752
]
Aleksei Zotov edited comment on CASSANDRA-16976 at 9/30/21, 12:51 PM:
----------------------------------------------------------------------
I dug deeper to unit stuff and I feel the current unit logic makes sense.
Possible units are: bytes, ranges, keys. They are applicable to different
compaction types. So "bytes" unit is not a measure of size (like byte, KB, MB,
etc) for progress/total, but rather is a sing that the numbers in
progress/total columns are measured in size (not a number of keys or ranges).
Basically that's why there is this condition that we need to convert
progress/total to human readable size format only if "size measurement" is
applicable:
{code:java}
boolean toFileSize = humanReadable && Unit.isFileSize(unit);{code}
Even though the current logic seems to be reasonable, "unit" name is
confusing. Maybe we can rename "unit" (both in nodetool and the VT)... For
example: "compaction unit" - it does not clarify a lot what it is, however, it
highlights it is not just a size unit.
WDYT guys?
was (Author: azotcsit):
I dug deeper to unit stuff and I feel the current unit logic makes sense.
Possible units are: bytes, ranges, keys. They are applicable to different
compaction types. So "bytes" unit is not a measure of size (like byte, KB, MB,
etc) for progress/total, but rather is a sing that the numbers in
progress/total columns are measured in size (not a number of keys or ranges).
Basically that's why there is this condition that we need to convert
progress/total to human readable size format only if "size measurement" is
applicable:
boolean toFileSize = humanReadable && Unit.isFileSize(unit);
Even though the current logic seems to be reasonable, "unit" name is
confusing. Maybe we can rename "unit" (both in nodetool and the VT)... For
example: "compaction unit" - it does not clarify a lot what it is, however, it
highlights it is not just a size unit.
WDYT guys?
> Make nodetool compactionstats and sstable_tasks consistent
> ----------------------------------------------------------
>
> Key: CASSANDRA-16976
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16976
> Project: Cassandra
> Issue Type: Task
> Components: Feature/Virtual Tables, Tool/nodetool
> Reporter: Aleksei Zotov
> Assignee: Aleksei Zotov
> Priority: Normal
> Fix For: 4.x
>
>
> Currently there is a difference in the output if {{nodetool compactionstats}}
> command and {{sstable_tasks}} virtual table (originally introduced by
> CASSANDRA-14457). They need to be aligned. The differences are:
>
> ||nodetool||VT||Comment||
> |percentComplete|completion_ratio|column naming is different only|
> |completed|progress|column naming is different only|
> |compaction type|kind|column naming is different only|
> |sstables|NA| |
> Additionally, please, update necessary documentation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
