[ https://issues.apache.org/jira/browse/CASSANDRA-17040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430805#comment-17430805 ]
Dinesh Joshi commented on CASSANDRA-17040: ------------------------------------------ I had to upgrade JNA to 5.9.0 on top of your Snappy patch. I ran all the unit tests. There were 3 failures but rest of them passed. Upon rerunning the failed tests individually they passed. I am going to poke around a little before approving this patch. We can get this into trunk certainly but I don't think we'll backport it to any of the release branches. > Upgrade Snappy version to support Apple M1 > ------------------------------------------ > > Key: CASSANDRA-17040 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17040 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Compression > Reporter: Yuqi Gu > Assignee: Yuqi Gu > Priority: Normal > Fix For: 4.1 > > Attachments: UTs.txt, UTs_2.txt > > Time Spent: 10m > Remaining Estimate: 0h > > Some Unit test cases were failed in Apple M1: > > {code:java} > [junit-timeout] Testcase: > testTableOptions(org.apache.cassandra.cql3.validation.miscellaneous.OverflowTest): > Caused an ERROR > [junit-timeout] SnappyCompressor.create() threw an error: > java.lang.NoClassDefFoundError Could not initialize class > org.xerial.snappy.Snappy > [junit-timeout] org.apache.cassandra.exceptions.ConfigurationException: > SnappyCompressor.create() threw an error: java.lang.NoClassDefFoundError > Could not initialize class org.xerial.snappy.Snappy > [junit-timeout] at > org.apache.cassandra.schema.CompressionParams.createCompressor(CompressionParams.java:344) > [junit-timeout] at > org.apache.cassandra.schema.CompressionParams.<init>(CompressionParams.java:211) > [junit-timeout] at > org.apache.cassandra.schema.CompressionParams.fromMap(CompressionParams.java:124) > [junit-timeout] at > org.apache.cassandra.cql3.statements.schema.TableAttributes.build(TableAttributes.java:110) > [junit-timeout] at > org.apache.cassandra.cql3.statements.schema.TableAttributes.validate(TableAttributes.java:58) > [junit-timeout] at > .... > ... > .. > > {code} > > Snappy-java added M1 support since > 1.1.8.2.([https://github.com/xerial/snappy-java/pull/268).] > So let's upgrade snappy-java dependency to the latest release 1.1.8.4. > > > > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org