[ 
https://issues.apache.org/jira/browse/CASSANDRA-17070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17435840#comment-17435840
 ] 

Berenguer Blasi commented on CASSANDRA-17070:
---------------------------------------------

[~adelapena] the reason to run that code twice was that the test keeps a list 
of the views. So if a cleanup failed the next one would pick up from the 
failing point

But +1 to the abstract class and unique MV name. I ported your changes to my PR 
but: I deleted the extra cleanup which is not needed anymore, I changed the 
config to run {{ViewComplex*Test}} instead of having one commit per repeat test 
and I attached results to the PR.

I am only on the fence about the cleanup logic, which we could remove now there 
are unique MV names, but on the other hand it's nice to have it. I think I am 
+1 on how things are right now. Wdyt?

> ViewComplexTest hardening
> -------------------------
>
>                 Key: CASSANDRA-17070
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17070
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Berenguer Blasi
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.0.x, 4.x
>
>
> I have seen a number of times already the {{ViewComplexTest}} family timeout 
> on test method teardown. This leaves a dirty env behind triggering the 
> following test methods to fail on it. This ticket aims at hardening them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to