[ 
https://issues.apache.org/jira/browse/CASSANDRA-17059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437399#comment-17437399
 ] 

Benedict Elliott Smith commented on CASSANDRA-17059:
----------------------------------------------------

bq. without having to maintain a full Cassandra fork

I think the size of fork is pretty minimal here, right? We're talking about a 
patch that adds some verbs to {{Verb}}?

I'll reserve judgement until I see the patch, but I think the codebase benefits 
from {{Verb}} being an {{enum}}, so unless the ergonomic gains for pluggability 
are really significant, or the penalty to the codebase really minimal, I remain 
in need of convincing - but hopefully the patch will do that!

Improvements to how {{Sink}} can be registered are easily accommodated, I'm 
sure.

> Support adding custom verbs at runtime
> --------------------------------------
>
>                 Key: CASSANDRA-17059
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17059
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Matt Fleming
>            Priority: Normal
>
> Cassandra already has support for registering custom verbs at build time, but 
> there's value in allowing verbs to be added at runtime since that enables new 
> use cases where it's inconvenient or impossible to modify the Cassandra 
> source.
> Additionally, apps that went to register new verbs benefit from running 
> custom code after the default verb handlers execute. This can be achieved 
> with straightforward modifications to the Sink interface (e.g. adding a 
> PostSink class).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to