[ https://issues.apache.org/jira/browse/CASSANDRA-17147 ]
Stefan Miklosovic deleted comment on CASSANDRA-17147:
-----------------------------------------------
was (Author: smiklosovic):
Well if we want to do that, then the whole patch as is now is just useless,
more or less. I think we would need to hook it here (1) with a lot of plumbing
around.
Anyway, in more general terms, do we trully need the heartbeat functionality
just for the resolution of gc grace period? Is not there any other usecase or
utility from keeping this check outside of commit log syncing? Are we sure we
want to couple heartbeats with that?
(1)
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/commitlog/AbstractCommitLogService.java#L189
> Guardrails prototype
> --------------------
>
> Key: CASSANDRA-17147
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17147
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 19h 50m
> Remaining Estimate: 0h
>
> The purpose of this ticket is creating an initial implementation of the
> guardrails framework, as well as adding a few simple guardrails using this
> framework.
> To keep things easy, this initial implementation would only support
> guardrails that are triggered on the coordinator, and they would be
> dynamically updatable only through JMX.
> Once we have this initial framework ready in a feature branch we can have
> multiple tickets addressing all the things that would have been left out of
> the scope of this ticket, such as:
> * Dynamic updates through virtual tables
> * Being able to notify about guardrails triggered on replicas
> * Using custom exceptions other than {{InvalidRequestException}}.
> * Porting existing limits to use the new guardrails framework
> * Adding new guardrails beyond the initial ones
> The reason for having this simpler prototype is that it will give us a common
> ground to parallelize work on the parts mentioned above.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
