[
https://issues.apache.org/jira/browse/CASSANDRA-17181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457800#comment-17457800
]
Ekaterina Dimitrova commented on CASSANDRA-17181:
-------------------------------------------------
Sure, I think this is nice cleaning.
I have only one small suggestion - can we add a comment or so in
{code:java}
SchemaCQLHelper.getTableMetadataAsCQL(TableMetadata metadata) {code}
for what those "{_}true{_}" state so that people do not need to go to the
actual functions to verify that? What do you think?
I also just propagated the patch to trunk too
[here|https://github.com/ekaterinadimitrova2/cassandra/pull/new/CASSANDRA-17181-review-trunk].
I can run final CI on both branches when we are done. (Side note - many tests
were failing in the CI run because it was run with lower resources, expected
behavior)
Side note for [~bkowalczyyk], if a branch or a PR in your fork is more
convenient for you to submit than creating a patch, that also works. It's up to
you - both PR or patch are accepted. Just realized we talk primarily about a
patch on the page you mentioned so probably a thing we can improve for people
there, to give them more options. :) Thank you for your work!
> SchemaCQLHelperTest methods can be simplified
> ---------------------------------------------
>
> Key: CASSANDRA-17181
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17181
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Benjamin Lerer
> Assignee: Bartlomiej
> Priority: Normal
> Labels: AdventCalendar2021, lhf
> Fix For: 4.0.x, 4.x
>
> Attachments: CASSANDRA-17181-4.0.patch
>
>
> {{SchemaCQLHelperTest}} is used during a snapshot to generate the
> {{schema.cql}} file. The methods accept the following paramaters:
> {{includeDroppedColumns}}, {{internals}} and {{ifNotExists}}.
> Those parameters are in practice always set to true by the calling code and
> therefore can be removed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
