[
https://issues.apache.org/jira/browse/CASSANDRA-17205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459404#comment-17459404
]
Josh McKenzie edited comment on CASSANDRA-17205 at 12/14/21, 6:42 PM:
----------------------------------------------------------------------
CI looks good except {{TestClientRequestMetricsLocalRemote}} which look both
new and to be failing on trunk. Thanks
[Butler!|https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-trunk/trunk]
Going to think for a couple minutes on whether it's worth it to logically tie
this "clear out sstable_activity and clear out {{{}TableMetrics{}}}" action
together or keep it bespoke for the {{Tidier}} here...
Edit: Nope. Literally only used in {{SSTableTidier}}
was (Author: jmckenzie):
CI looks good except {{TestClientRequestMetricsLocalRemote}} which look both
new and to be failing on trunk. Thanks
[Butler!|https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-trunk/trunk]
Going to think for a couple minutes on whether it's worth it to logically tie
this "clear out sstable_activity and clear out {{TableMetrics}}" action
together or keep it bespoke for the {{Tidier}} here...
> File leaks will not be be detected and released due to strong self-references
> in the tidier
> -------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17205
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
> Reporter: Josh McKenzie
> Assignee: Josh McKenzie
> Priority: Normal
>
> LogTransaction.SSTableTidier holds a reference to a {{Tracker}} which holds
> references to both a {{ColumnFamilyStore}} and a {{View}}, both of which hold
> refs to SSTableReaders. As per the comment at the top of the SSTableTidier:
> {quote}// must not retain a reference to the SSTableReader, else leak
> detection cannot kick in
> {quote}
> We shouldn't hold a reference to the Tracker here; long running unit tests
> w/-Dcassandra.debugrefcount=true had this pop up.
> {code}ERROR [Strong-Reference-Leak-Detector:1] 2020-10-27T01:10:12,421
> NoSpamLogger.java:97 - Strong self-ref loop detected{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
