[ 
https://issues.apache.org/jira/browse/CASSANDRA-17209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461030#comment-17461030
 ] 

Caleb Rackliffe commented on CASSANDRA-17209:
---------------------------------------------

+1 w/ minor nits in the PR

> Avoid unecessary array allocations and initializations in RequestValidations
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17209
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17209
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Interpreter
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>            Priority: Normal
>             Fix For: 4.x
>
>
> {{RequestValidations}} methods used extensively varargs. As the array 
> creation is necessary only when the check fail we endup creating most of the 
> time unecessary array. This can easily be avoided by overloading the 
> different methods with a number of message argument from zero to three. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to