[ https://issues.apache.org/jira/browse/CASSANDRA-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471990#comment-17471990 ]
Benedict Elliott Smith commented on CASSANDRA-6936: --------------------------------------------------- I trust you to have made good choices, [~blambov]. I'll see if I can find some time to get an overview the work for some high level feedback about the serialisation format, but I haven't thought about this problem domain in a long time so my consideration may be less valuable than you imagine. I won't likely have the time to perform a full review either way. > Make all byte representations of types comparable by their unsigned byte > representation only > -------------------------------------------------------------------------------------------- > > Key: CASSANDRA-6936 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6936 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core > Reporter: Benedict Elliott Smith > Assignee: Branimir Lambov > Priority: Normal > Labels: compaction, performance > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > This could be a painful change, but is necessary for implementing a > trie-based index, and settling for less would be suboptimal; it also should > make comparisons cheaper all-round, and since comparison operations are > pretty much the majority of C*'s business, this should be easily felt (see > CASSANDRA-6553 and CASSANDRA-6934 for an example of some minor changes with > major performance impacts). No copying/special casing/slicing should mean > fewer opportunities to introduce performance regressions as well. > Since I have slated for 3.0 a lot of non-backwards-compatible sstable > changes, hopefully this shouldn't be too much more of a burden. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org