[ 
https://issues.apache.org/jira/browse/CASSANDRA-17243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475554#comment-17475554
 ] 

Andres de la Peña commented on CASSANDRA-17243:
-----------------------------------------------

Yep, I also think that the difference in throughput is pretty small and 
unlikely to have an impact in practice. Probably adding that NEWS.txt entry is 
enough to cover those hypothetical cases where that could be a problem, while 
achieving correctness in all branches.

> Fix BYTES_PER_MEGABIT in StreamManager
> --------------------------------------
>
>                 Key: CASSANDRA-17243
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17243
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Consistency/Streaming
>            Reporter: Ekaterina Dimitrova
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> While working on CASSANDRA-15234 I noticed BYTES_PER_MEGABIT constant in the 
> {code:java}
> StreamManager
> {code}
>  class. It was introduced in CASSANDRA-16959.
> The current formula converts actually bytes to mebibits. 
> The change needed for 3.0, 3.11 and 4.0(I am currently changing rate 
> parameters to be in MiB/s for trunk as part of CASSANDRA-15234):
> {code:java}
> public static final double BYTES_PER_MEGABIT = (1000 * 1000) / 8; // from bits
> {code}
> CC [~adelapena]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to