[
https://issues.apache.org/jira/browse/CASSANDRA-15234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476514#comment-17476514
]
Ekaterina Dimitrova commented on CASSANDRA-15234:
-------------------------------------------------
The [PR|https://github.com/ekaterinadimitrova2/cassandra/pull/191/files] is
ready for final round in my opinion.
All three branches -
[CCM|https://github.com/ekaterinadimitrova2/ccm/tree/CASSANDRA-15234],
[Cassandra|https://github.com/ekaterinadimitrova2/cassandra/tree/15234-take2-review]
and [DTest
repo|https://github.com/ekaterinadimitrova2/cassandra-dtest/tree/CASSANDRA-15234-take2]
were rebased and any outstanding issues fixed.
+*Exception:*+
* The VT Settings related tests are failing because of the issue I mentioned
in my previous comment around _key_cache_save_period, row_cache_save_period and
counter_cache_save_period._
* There are a few tests failing with byteman related issues. I suspect
CircleCI might be acting weird. The tests complete fine locally. I just pushed
a run in Jenkins
[here|https://jenkins-cm4.apache.org/job/Cassandra-devbranch/1370/] which I
will double check tomorrow.
> Standardise config and JVM parameters
> -------------------------------------
>
> Key: CASSANDRA-15234
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15234
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Benedict Elliott Smith
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
> Attachments: CASSANDRA-15234-3-DTests-JAVA8.txt
>
>
> We have a bunch of inconsistent names and config patterns in the codebase,
> both from the yams and JVM properties. It would be nice to standardise the
> naming (such as otc_ vs internode_) as well as the provision of values with
> units - while maintaining perpetual backwards compatibility with the old
> parameter names, of course.
> For temporal units, I would propose parsing strings with suffixes of:
> {{code}}
> u|micros(econds?)?
> ms|millis(econds?)?
> s(econds?)?
> m(inutes?)?
> h(ours?)?
> d(ays?)?
> mo(nths?)?
> {{code}}
> For rate units, I would propose parsing any of the standard {{B/s, KiB/s,
> MiB/s, GiB/s, TiB/s}}.
> Perhaps for avoiding ambiguity we could not accept bauds {{bs, Mbps}} or
> powers of 1000 such as {{KB/s}}, given these are regularly used for either
> their old or new definition e.g. {{KiB/s}}, or we could support them and
> simply log the value in bytes/s.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
