[
https://issues.apache.org/jira/browse/CASSANDRA-17212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480205#comment-17480205
]
Benedict Elliott Smith edited comment on CASSANDRA-17212 at 1/21/22, 5:51 PM:
------------------------------------------------------------------------------
Discoverability remains poor, as previously mentioned, but also this is almost
inherently inconsistent as we are already grouping under a concept heading by
using {{limits}}. What about other {{row_index}} things that aren't limits?
I also don't think a discussion can ignore how this fits in with other limits,
such as concurrency, throughput etc., which looks particularly messy (and
materially harms discovery of these pieces) as well as complicates
documentation.
We also need to look at consistency of e.g. {{local_read_size}} versus
{{large_partition}} (no size).
For example, is this how you view the other properties?
{code}
limits:
reads:
concurrency: 32
writes:
concurrency: 32
counter_writes:
concurrency: 32
materialized_view_writes:
concurrency: 32
clients:
concurrency: 128
hint_delivery:
concurrency: 2
flush:
concurrency: 2
compaction:
concurrency: 1
repair:
concurrency: 0
auto_sstable_upgrades:
concurrency: 1
streaming:
local:
throughput: 25MiB/s
remote:
throughput: 25MiB/s
batchlog:
throughput: 1MiB/s
compaction:
throughput: 16MiB/s
hint_delivery:
throughput: 1MiB/s
memtable:
heap_capacity: 2048mb
offheap_capacity: 2048mb
compressed_chunks_cache:
capacity: 512MiB
key_index_cache:
row_index_size_limit: 2KiB
capacity: 0MiB
network:
tcp:
send_buffer_size: 512MiB
recv_buffer_size: 512MiB
connection:
send_queue_size: 4MiB
recv_queue_size: 4MiB
endpoint:
send_queue_size: 128MiB
recv_queue_size: 128MiB
global:
send_queue_size: 512MiB
recv_queue_size: 512MiB
{code}
I think you also then need to start asking difficult questions like, is
streaming a network limit? Will the user expect your choice here?
It is however trivial for the user to say "is this a throughput limit?" and
then find the relevant one.
was (Author: benedict):
Discoverability remains poor, as previously mentioned, but also this is almost
inherently inconsistent as we are already grouping under a concept heading by
using {{limits}}. What about other {{row_index}} things that aren't limits?
I also don't think a discussion can ignore how this fits in with other limits,
such as concurrency, throughput etc., which looks particularly messy (and
materially harms discovery of these pieces) as well as complicates
documentation.
We also need to look at consistency of e.g. {{local_read_size}} versus
{{large_partition}} (no size).
> Migrate threshold for minimum keyspace replication factor to guardrails
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-17212
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17212
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Priority: Normal
>
> The config property
> [{{minimum_keyspace_rf}}|https://github.com/apache/cassandra/blob/5fdadb25f95099b8945d9d9ee11d3e380d3867f4/conf/cassandra.yaml]
> that was added by CASSANDRA-14557 can be migrated to guardrails, for example:
> {code}
> guardrails:
> ...
> replication_factor:
> warn_threshold: 2
> abort_threshold: 3
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
