[
https://issues.apache.org/jira/browse/CASSANDRA-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480292#comment-17480292
]
Blake Eggleston commented on CASSANDRA-17164:
---------------------------------------------
So this looks pretty good for the most part, I don’t have any high level
concerns about the patch. I have a branch here with some minor changes:
[https://github.com/bdeggleston/cassandra/tree/17164-trunk-review]
Other feedback / questions:
* Config
** additional comments around some of the config options would be useful
* DatabaseDescriptor
** Why did you remove the logged warning about non linearizable reads?
* QueryProcessor
** Why did you change {{type.decompose}} to {{type.decomposeUntyped}} in
{{makeInternalOptionsWithNowInSec}}??
* AbstractBTreePartition / PartitionUpdate
** this equals method is going to cause confusion and possibly bugs in the
future. I’d opt for a standard equals/hashCode implementation either here or in
PartitionUpdate, and if you need something more specific for tests, I’d write
an assert method for those tests, especially since it’s not checking for the
partition key or static row
* PaxosCleanup
** should we log out of range requests in {{isInRangeAndShouldProcess}}?
* PaxosCleanupScheduler
** Doesn’t seem to be used outside of tests
* PaxosState
** I’d prefer we use {{.equals}} instead of checking pointer equality here.
{{.equals}} should check for pointer equality, but will also guard against
unintended behavior if logically identical but different objects end up in
these fields.
* UncommittedTableData
** Regarding your TODO in {{CFSFilterFactory,getReplicatedRanges}}, WDYT about
returning an empty collection if we don’t know about the table?
* Ballot/TimeUUID
** WDYT about renaming {{rawTimestamp}} to {{uuidTimestamp}}? Raw is ambiguous
* BufferPool
** These changes seem like they may have been for debugging purposes, are they
something that should be committed?
In addition to more docs around the config options, we should include docs
explaining what v2 is, and when/why you’d want to use it. A description and
explanation of the upgrade procedure should also be included, as well as an
entry in NEWS.txt.
> CEP-14: Paxos Improvements
> --------------------------
>
> Key: CASSANDRA-17164
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17164
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Coordination, Consistency/Repair
> Reporter: Benedict Elliott Smith
> Assignee: Benedict Elliott Smith
> Priority: Normal
> Fix For: 4.1
>
>
> This ticket encompasses work for [CEP-14|
> https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-14%3A+Paxos+Improvements].
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
