[ https://issues.apache.org/jira/browse/CASSANDRA-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482510#comment-17482510 ]
Benedict Elliott Smith edited comment on CASSANDRA-17164 at 1/26/22, 2:18 PM: ------------------------------------------------------------------------------ I think this would be fine, I need to think through why I did not do this originally, as I did consider it. It may simply have been to minimise the change in semantics to {{system.paxos}}, without there having been any particularly good reason. Perhaps also for debugging purposes, it helps to be able to see whether something had been promised before it was accepted/committed. I think there is perhaps also some additional complexity when a replica has promised a ballot with the same timestamp, and then proceed to accept it. I don't think we would resolve these reliably, so we might not actually overwrite it anyway, and I don't think there is a trivial solution to this problem in the storage layer. I'm not certain if this would actually cause problems, but it would require some careful consideration to rule it out. was (Author: benedict): I think this would be fine, I need to think through why I did not do this originally, as I did consider it. It may simply have been to minimise the change in semantics to {{system.paxos}}, without there having been any particularly good reason. Perhaps also for debugging purposes, it helps to be able to see whether something had been promised before it was accepted/committed. I think there is perhaps also some additional complexity when a replica has promised a ballot with the same timestamp, and then proceed to accept it. I don't think we would resolve these reliably, so we might not actually overwrite it anyway, and I don't think there is a trivial solution to this problem in the storage layer. > CEP-14: Paxos Improvements > -------------------------- > > Key: CASSANDRA-17164 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17164 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Coordination, Consistency/Repair > Reporter: Benedict Elliott Smith > Assignee: Benedict Elliott Smith > Priority: Normal > Fix For: 4.1 > > > This ticket encompasses work for [CEP-14| > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-14%3A+Paxos+Improvements]. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org