[
https://issues.apache.org/jira/browse/CASSANDRA-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485380#comment-17485380
]
Andres de la Peña commented on CASSANDRA-17048:
-----------------------------------------------
The failure at {{testGetTemporaryFilesSafeAfterObsoletion}} is being addressed
by CASSANDRA-17286, and the failure at {{test_atomic_writes}} has
CASSANDRA-17289. As for the other dtest failures, the seem related to recent
problems with Byteman scripts, and might have been fixed by CASSANDRA-17265.
Here is a new CI round over the rebased patch, including j8's upgrade tests:
||Branch||CI||
|[trunk|https://github.com/adelapena/cassandra/tree/17048-trunk-review-rebase]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1275/workflows/e278b53d-09e5-430a-affd-416387c91007]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1275/workflows/fb13e232-6021-4a19-b304-a51f004025b6]|
The last test fixes look good to me. Besides a couple of typos, my only
remaining concern is that we are mixing terminology a bit by naming attributes
and parameters of type {{SSTableId}} as {{{}generation{}}}, which might make
the code a bit confusing, as it's mentioned
[here|https://github.com/apache/cassandra/pull/1276#discussion_r768668771].
[~blerer] wdyt?
> Replace sequential sstable generation identifier with UUID v1
> -------------------------------------------------------------
>
> Key: CASSANDRA-17048
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17048
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/SSTable
> Reporter: Jacek Lewandowski
> Assignee: Jacek Lewandowski
> Priority: Normal
> Fix For: 4.1
>
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Replace the current sequential sstable generation identifier with ULID based.
> ULID is better because we do not need to scan the existing files to pick the
> starting number as well as we can generate globally unique identifiers.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
