[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488207#comment-17488207
]
Alex Petrov commented on CASSANDRA-17332:
-----------------------------------------
+1 ; the only thing I'd theoretically change is maybe return some structure
that would avoid re-wrapping in array list every time we call for node id
[here|https://github.com/apache/cassandra-in-jvm-dtest-api/pull/31/files#diff-41aeaeb3abc0a6c5541dbb4acf7e8ec4432fdf02ace61f5e7db00b7834f63729R56],
but this is fairly minor, so I'll leave it for [~dcapwell]'s discresion
> Add support for vnodes in jvm-dtest
> -----------------------------------
>
> Key: CASSANDRA-17332
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17332
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.x
>
>
> Right now python dtests need to keep running after being ported to jvm-dtests
> as vnode support is not present, to fully deprecate the python dtests, we
> need vnode support in jvm-dtest.
> Sadly, to add support we need to break binary compatibility, but can maintain
> source compatibility… so will need to bump every jar across every branch
> (mostly due to TokenSupplier)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
