[ 
https://issues.apache.org/jira/browse/CASSANDRA-17198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492379#comment-17492379
 ] 

Berenguer Blasi commented on CASSANDRA-17198:
---------------------------------------------

Hi [~subkanthi],

the code you have so far is great. But as you can see in the CI run above some 
of the tests failed because the behavior for the {{LIKE}} operator has changed. 
Those tests need to be amended to the new behavior. Please notice trunk has 
[currently|https://ci-cassandra.apache.org/job/Cassandra-trunk/] some failures. 
So you can check current failures vs your branch failures and you should only 
fix those tests failing because of the changes to {{LIKE}}. Makes sense? Let me 
know any questions please.

> Allow to filter using LIKE predicates
> -------------------------------------
>
>                 Key: CASSANDRA-17198
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17198
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Syntax
>            Reporter: Benjamin Lerer
>            Assignee: Kanthi Subramanian
>            Priority: Normal
>              Labels: AdventCalendar2021, lhf
>             Fix For: 4.x
>
>
> {{LIKE}} predicates can only be used with the SASI indices. In several 
> usecases (e.g. querying the {{settings}} virtual table) it makes sense to 
> support them for filtering.
> +Additional information for newcomers:+
> There are some checks in the {{StatementRestrictions}} constructor and on 
> {{LikeRestriction}} that need to be removed for allowing filtering using LIKE 
> on clustering and regular columns.
> For filtering on partition columns the {{needFiltering}} methods in 
> {{PartitionKeySingleRestrictionSet}} will need to be modified to return true 
> when LIKE predicate are used.
> The unit tests should go in {{SelectTest}}.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to