[
https://issues.apache.org/jira/browse/CASSANDRA-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492763#comment-17492763
]
Caleb Rackliffe commented on CASSANDRA-17272:
---------------------------------------------
+1 w/ minor nits on all 3 PRs (and assuming 4.0 will merge cleanly to trunk)
Just to make sure I have things straight, the only difference between 3.0 and
3.11+ is the latter avoids the unnecessary call to {{getWriteDirectory()}} in
the various {{realAppend()}} overrides?
> LeveledCompactionStrategy disk space check improvements
> -------------------------------------------------------
>
> Key: CASSANDRA-17272
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17272
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction/LCS
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We currently allow reducing scope (removing sstables from the compaction)
> when starting STCS-in-L0 with LCS if the compaction is too large for the
> available disk space. We can do the same for L0 -> L1 compactions - but we
> can only remove L0 sstables to avoid causing overlap in L1.
> Also, in 3.0, when starting an LCS compaction we try to [get a writeable
> location|https://github.com/apache/cassandra/blob/b1a8a56c563b85ab9a34d3bbf9c16278dd441157/src/java/org/apache/cassandra/db/compaction/writers/CompactionAwareWriter.java#L128]
> where the full result of the compaction will fit - here we should only get a
> directory where the first sstable fits, otherwise the compaction might fail
> even though there is enough space in total among the data directories
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
