[
https://issues.apache.org/jira/browse/CASSANDRA-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Ellis updated CASSANDRA-2850:
--------------------------------------
Attachment: 2850-rebased.txt
Still getting the same errors on FBUtilities, but I merged it in manually.
Result is attached.
Getting test failures like this:
{noformat}
[junit] Testcase:
testCleanupWithIndexes(org.apache.cassandra.db.CleanupTest): Caused an
ERROR
[junit] 312
[junit] java.lang.ArrayIndexOutOfBoundsException: 312
[junit] at
org.apache.cassandra.utils.ByteBufferUtil.bytesToHex(ByteBufferUtil.java:489)
[junit] at
org.apache.cassandra.db.marshal.LocalByPartionerType.getString(LocalByPartionerType.java:53)
[junit] at org.apache.cassandra.db.Column.getString(Column.java:229)
[junit] at
org.apache.cassandra.db.filter.SliceQueryFilter.collectReducedColumns(SliceQueryFilter.java:123)
[junit] at
org.apache.cassandra.db.filter.QueryFilter.collectCollatedColumns(QueryFilter.java:142)
[junit] at
org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:1312)
[junit] at
org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1189)
[junit] at
org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1146)
[junit] at
org.apache.cassandra.db.ColumnFamilyStore.scan(ColumnFamilyStore.java:1501)
[junit] at
org.apache.cassandra.db.CleanupTest.testCleanupWithIndexes(CleanupTest.java:112)
[junit]
[junit]
[junit] Test org.apache.cassandra.db.CleanupTest FAILED
{noformat}
> Converting bytes to hex string is unnecessarily slow
> ----------------------------------------------------
>
> Key: CASSANDRA-2850
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2850
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: David Allsopp
> Assignee: David Allsopp
> Priority: Minor
> Fix For: 0.8.2
>
> Attachments: 2850-rebased.txt, 2850-v2.patch, 2850-v4.patch,
> 2850-v4a.patch, BytesToHexBenchmark.java, BytesToHexBenchmark2.java,
> BytesToHexBenchmark3.java, cassandra-2850a.diff
>
>
> ByteBufferUtil.bytesToHex() is unnecessarily slow - it doesn't pre-size the
> StringBuilder (so several re-sizes will be needed behind the scenes) and it
> makes quite a few method calls per byte.
> (OK, this may be a premature optimisation, but I couldn't resist, and it's a
> small change)
> Will attach patch shortly that speeds it up by about x3, plus benchmarking
> test.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
