[ 
https://issues.apache.org/jira/browse/CASSANDRA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497759#comment-17497759
 ] 

David Capwell commented on CASSANDRA-17378:
-------------------------------------------

I am cool with the patch adding back all configs and leaving type change to 
CASSANDRA-17166.  Thanks for adding in 
https://github.com/apache/cassandra/commit/537ad9e17b820e48df78a7edfe6b3a17d56e08bc,
 this will let me remove the special case from my diff test.

bq. If something changes and we want to bump to 5.0 and really remove all 
those, we can do that

when trunk turns into 5.0, then works for me

> Add backward compatibility for a few changes done in 15234
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-17378
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17378
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Build
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.x
>
>
> Based on the latest ML conversations, the following changes in Config should 
> be reconsidered:
> [https://github.com/apache/cassandra/commit/c51a7c66fc21ca2da08b89ae5f9b4817ee4d8c23]
>  * max_streaming_retries - deprecated long time ago but it should be there 
> until at least 5.0. We need to revert this change
>  * user_defined_function_warn_timeout_in_ms and 
> user_defined_function_fail_timeout_in_ms - add @Replaces annotation and I 
> think it is nice to transfer them to the new types too. *NOTE: Don't forget 
> to add the backward compatibility for those two in CCM by adding entries 
> [here|https://github.com/riptano/ccm/blob/master/ccmlib/common.py#L62-L148]; 
> valid for any parameter that will use the new framework and we want to be 
> backward compatible and tested properly by DTests*



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to