[
https://issues.apache.org/jira/browse/CASSANDRA-17220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498255#comment-17498255
]
Paulo Motta commented on CASSANDRA-17220:
-----------------------------------------
This looks great +1. If you agree can you incorporate [this
commit|https://github.com/pauloricardomg/cassandra/commit/956f6def4f12622efa914f3f08d6747bfc278953]
updating the {{cassandra.yaml}} wording? I tried to reduce the amount of text
between the properties.
Also, one final nitpicking before we merge:
* Should we make startup check names be prefixed with {{check_}} ? Ie.
{{{}check_dc{}}}, {{{}check_rack{}}}, etc (instead of simply {{dc}} or
{{{}rack{}}})? This will make it easier to figure out what the startup check
does. The renamed checks would be:
{code:yaml}
startup_checks:
check_filesystem_ownership:
enabled: false
ownership_token: "sometoken" # (overriden by "CassandraOwnershipToken"
system property)
ownership_filename: ".cassandra_fs_ownership" # (overriden by
"cassandra.fs_ownership_filename")
check_dc:
enabled: true # (overriden by cassandra.ignore_dc system property)
check_rack:
enabled: true # (overriden by cassandra.ignore_rack system property)
{code}
What do you think [~smiklosovic] [~dcapwell] ?
> Make startup checks configurable
> --------------------------------
>
> Key: CASSANDRA-17220
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17220
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
>
> This ticket was created from needs discovered in CASSANDRA-17180. We want to
> be able to configure a startup check so we figured out that it is necessary
> to treat all startup checks same - to be able to configure them. This ticket
> is about making startup checks configurable.
> Once this ticket is done, we can continue with the implementation of
> CASSANDRA-17180 where the implementation of gc grace check will be done.
> We have identified that there is one check currently in place which needs to
> be changed to reflect this configuration implementation and that is
> FileSystemOwnershipCheck.
> Because startup checks were not configurable before via means of a
> configuration file, they were configurable via system properties. This ticket
> does not aim to get rid system properties configuration mechanism, system
> properties will have precedence over settings in configuration file. Then, in
> the next release, I am aiming to get rid of system properties configuration
> mechanism.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
