[
https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500917#comment-17500917
]
Stefan Miklosovic commented on CASSANDRA-17413:
-----------------------------------------------
[~bschoeni]
could you spend more time on this, please? I used "pyflakes" (installed by pip)
against the sources and this is what I got:
{code}
$ pyflakes .
./copyutil.py:53:1 'cassandra.cqltypes.BytesType' imported but unused
./copyutil.py:58:1 redefinition of unused 'profile_on' from line 44
./copyutil.py:58:1 redefinition of unused 'profile_off' from line 44
./copyutil.py:204:30 undefined name 'errno'
./tracing.py:17:1 'datetime.timedelta' imported but unused
./cqlhandling.py:118:13 local variable 'str_token' is assigned to but never used
./test/test_cqlsh_output.py:405:13 'pytz' imported but unused
./test/ansi_colors.py:153:9 local variable 'oldclr' is assigned to but never
used
./test/__init__.py:17:1 '.cassconnect.create_db' imported but unused
./test/__init__.py:17:1 '.cassconnect.remove_db' imported but unused
{code}
this is against cqlsh.py
{code}
$ pyflakes cqlsh.py
cqlsh.py:141:1 'cassandra.metadata.protect_name' imported but unused
cqlsh.py:141:1 'cassandra.metadata.protect_names' imported but unused
cqlsh.py:153:1 'cqlshlib.cqlhandling' imported but unused
cqlsh.py:157:1 'cqlshlib.formatting.formatter_for' imported but unused
cqlsh.py:161:1 'cqlshlib.util.trim_if_present' imported but unused
cqlsh.py:259:17 '...'.format(...) has unused arguments at position(s): 0, 1
{code}
Would be nice if we took more in-depth approach here!
> Remove unused imports
> ---------------------
>
> Key: CASSANDRA-17413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17413
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Interpreter
> Reporter: Brad Schoening
> Assignee: Brad Schoening
> Priority: Normal
> Fix For: 4.x
>
>
> Python3 no longer requires the import of unicode_literals from futures. This
> and a few other unused imports, should be removed.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
