[
https://issues.apache.org/jira/browse/CASSANDRA-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502267#comment-17502267
]
Jan Karlsson edited comment on CASSANDRA-17407 at 3/8/22, 7:18 AM:
-------------------------------------------------------------------
Valid point, although I am not sure how much use the average person will get
out of it. Datacenter names usually have some pattern that makes it easy to see
errors. Even with 10 dcs, it would be rather easy for the user to do a nodetool
status and compare the lists. Although I suppose a more precise error message
couldn't hurt and the improved validation on the dtest would be good.
||Branch||Circle||dtest||
|[3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...itskarlsson:c17407-3.11?expand=1]|[CircleCI|https://app.circleci.com/pipelines/github/itskarlsson/cassandra/10/workflows/f5008a69-2798-4b03-802d-fb6d0128d68a]|[dtest|https://github.com/apache/cassandra-dtest/compare/trunk...itskarlsson:c17407-trunk?expand=1]|
edit: Fixed 3.11 link
was (Author: jan karlsson):
Valid point, although I am not sure how much use the average person will get
out of it. Datacenter names usually have some pattern that makes it easy to see
errors. Even with 10 dcs, it would be rather easy for the user to do a nodetool
status and compare the lists. Although I suppose a more precise error message
couldn't hurt and the improved validation on the dtest would be good.
||Branch||Circle||dtest||
|[3.11|https://github.com/apache/cassandra-dtest/compare/trunk...itskarlsson:c17407-trunk?expand=1]|[CircleCI|https://app.circleci.com/pipelines/github/itskarlsson/cassandra/10/workflows/f5008a69-2798-4b03-802d-fb6d0128d68a]|[dtest|https://github.com/apache/cassandra-dtest/compare/trunk...itskarlsson:c17407-trunk?expand=1]|
> Validate existence of DCs when repairing
> ----------------------------------------
>
> Key: CASSANDRA-17407
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17407
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
> Reporter: Jan Karlsson
> Assignee: Jan Karlsson
> Priority: Normal
> Fix For: 3.11.x, 4.0.x
>
>
> With the new validation of data centers in the replication factor, it might
> be good to give similar treatment to repair.
> Currently the behavior of the --in-dc flag only validates that it contains
> the local data center.
> If a list is given containing nonexistent data centers, the repair will pass
> without errors or warning as long as this list also contains the local data
> center.
> My suggestion would be to validate all the data centers and give an error
> when a nonexistent data center is given.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
