[ 
https://issues.apache.org/jira/browse/CASSANDRA-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506404#comment-17506404
 ] 

Josh McKenzie commented on CASSANDRA-17044:
-------------------------------------------

So the big caveat to the following: ASF Jenkins infra has had some disk space 
issues and builds not even completing, so it's quite possible the below 
failures are due to the environment and not this patch. There's one test that 
looks like it didn't have a record before this commit and is failing now: 
https://ci-cassandra.apache.org/job/Cassandra-trunk/1005/testReport/junit.framework/TestSuite/

We've had failures on trunk steadily creeping up over the course of 4 or so 
commits but it's also right after a stretch of 4 or so failed builds.

[CI Results]
Branch: trunk, build number: 1005
jenkins url: [https://ci-cassandra.apache.org/job/Cassandra-trunk/1005/]
JIRA: CASSANDRA-17044
commit url: 
[https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=2b2c6decfafc6235ad537e72073fab2fd4467e2f]
affected paths:
 * src/java/org/apache/cassandra/cql3/QueryProcessor.java
 * test/unit/org/apache/cassandra/db/compaction/CompactionsTest.java
 * test/unit/org/apache/cassandra/SchemaLoader.java
 * src/java/org/apache/cassandra/tools/SSTableLevelResetter.java
 * test/unit/org/apache/cassandra/locator/AssureSufficientLiveNodesTest.java
 * test/unit/org/apache/cassandra/utils/CassandraGenerators.java
 * src/java/org/apache/cassandra/schema/Diff.java
 * src/java/org/apache/cassandra/schema/MigrationCoordinator.java
 * test/unit/org/apache/cassandra/db/SystemKeyspaceTest.java
 * src/java/org/apache/cassandra/service/PendingRangeCalculatorService.java
 * src/java/org/apache/cassandra/repair/consistent/admin/SchemaArgsParser.java
 * src/java/org/apache/cassandra/schema/SchemaMigrationDiagnostics.java
 * test/unit/org/apache/cassandra/db/RowCacheTest.java
 * src/java/org/apache/cassandra/schema/SchemaTransformation.java
 * test/unit/org/apache/cassandra/service/paxos/uncommitted/PaxosRowsTest.java
 * test/unit/org/apache/cassandra/db/commitlog/CommitLogTest.java
 * src/java/org/apache/cassandra/schema/Keyspaces.java
 * test/unit/org/apache/cassandra/db/compaction/CompactionTaskTest.java
 * src/java/org/apache/cassandra/schema/SchemaTransformations.java
 * src/java/org/apache/cassandra/schema/OfflineSchemaUpdateHandler.java
 * src/java/org/apache/cassandra/db/guardrails/Guardrails.java
 * src/java/org/apache/cassandra/dht/BootStrapper.java
 * src/java/org/apache/cassandra/net/MessagingService.java
 * test/unit/org/apache/cassandra/db/view/ViewUtilsTest.java
 * src/java/org/apache/cassandra/tools/StandaloneSplitter.java
 * 
test/unit/org/apache/cassandra/db/streaming/EntireSSTableStreamConcurrentComponentMutationTest.java
 * test/unit/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriterTest.java
 * src/java/org/apache/cassandra/schema/DefaultSchemaUpdateHandler.java
 * src/java/org/apache/cassandra/utils/FBUtilities.java
 * test/unit/org/apache/cassandra/db/SecondaryIndexTest.java
 * test/unit/org/apache/cassandra/db/ReadCommandTest.java
 * test/unit/org/apache/cassandra/db/SchemaCQLHelperTest.java
 * src/java/org/apache/cassandra/gms/Gossiper.java
 * test/unit/org/apache/cassandra/db/compaction/CompactionsBytemanTest.java
 * src/java/org/apache/cassandra/db/commitlog/CommitLog.java
 * src/java/org/apache/cassandra/tools/StandaloneSSTableUtil.java
 * src/java/org/apache/cassandra/service/CassandraDaemon.java
 * test/unit/org/apache/cassandra/hints/HintTest.java
 * src/java/org/apache/cassandra/schema/SchemaChangeNotifier.java
 * test/unit/org/apache/cassandra/cql3/ViewSchemaTest.java
 * test/unit/org/apache/cassandra/locator/SimpleStrategyTest.java
 * src/java/org/apache/cassandra/tools/SSTableOfflineRelevel.java
 * 
test/simulator/main/org/apache/cassandra/simulator/cluster/OnInstanceSyncSchemaForBootstrap.java
 * src/java/org/apache/cassandra/schema/Types.java
 * tools/stress/src/org/apache/cassandra/stress/CompactionStress.java
 * src/java/org/apache/cassandra/batchlog/BatchlogManager.java
 * test/distributed/org/apache/cassandra/distributed/impl/Instance.java
 * test/unit/org/apache/cassandra/service/LeaveAndBootstrapTest.java
 * src/java/org/apache/cassandra/cache/AutoSavingCache.java
 * test/unit/org/apache/cassandra/service/StorageServiceServerTest.java
 * src/java/org/apache/cassandra/net/MessagingServiceMBeanImpl.java
 * src/java/org/apache/cassandra/schema/DefaultSchemaUpdateHandlerFactory.java
 * 
test/distributed/org/apache/cassandra/distributed/test/metric/TableMetricTest.java
 * test/unit/org/apache/cassandra/schema/SchemaTestUtil.java
 * test/unit/org/apache/cassandra/db/commitlog/CommitLogUpgradeTest.java
 * 
src/java/org/apache/cassandra/cql3/statements/schema/CreateTableStatement.java
 * src/java/org/apache/cassandra/schema/KeyspaceMetadata.java
 * test/unit/org/apache/cassandra/service/OptionalTasksTest.java
 * src/java/org/apache/cassandra/tools/SSTableExpiredBlockers.java
 * test/unit/org/apache/cassandra/db/RangeTombstoneTest.java
 * src/java/org/apache/cassandra/utils/Collectors3.java
 * src/java/org/apache/cassandra/index/SecondaryIndexManager.java
 * src/java/org/apache/cassandra/schema/SchemaChangeListener.java
 * test/unit/org/apache/cassandra/triggers/TriggersSchemaTest.java
 * src/java/org/apache/cassandra/schema/DistributedSchema.java
 * test/unit/org/apache/cassandra/service/MoveTest.java
 * test/unit/org/apache/cassandra/cql3/validation/entities/UFTest.java
 * test/unit/org/apache/cassandra/schema/SchemaMutationsSerializerTest.java
 * 
test/unit/org/apache/cassandra/cql3/validation/operations/CompactTableTest.java
 * src/java/org/apache/cassandra/tools/StandaloneUpgrader.java
 * src/java/org/apache/cassandra/schema/SchemaUpdateHandlerFactoryProvider.java
 * test/microbench/org/apache/cassandra/test/microbench/BatchStatementBench.java
 * test/unit/org/apache/cassandra/db/compaction/TTLExpiryTest.java
 * test/unit/org/apache/cassandra/db/CounterCacheTest.java
 * src/java/org/apache/cassandra/net/Verb.java
 * test/unit/org/apache/cassandra/dht/BootStrapperTest.java
 * src/java/org/apache/cassandra/schema/TableMetadataRefCache.java
 * 
test/distributed/org/apache/cassandra/distributed/test/ring/BootstrapTest.java
 * src/java/org/apache/cassandra/db/ColumnFamilyStore.java
 * src/java/org/apache/cassandra/schema/SchemaDiagnostics.java
 * tools/stress/src/org/apache/cassandra/io/sstable/StressCQLSSTableWriter.java
 * test/unit/org/apache/cassandra/schema/MigrationCoordinatorTest.java
 * test/unit/org/apache/cassandra/cql3/KeyCacheCqlTest.java
 * src/java/org/apache/cassandra/schema/TableId.java
 * test/unit/org/apache/cassandra/schema/SchemaKeyspaceTest.java
 * test/unit/org/apache/cassandra/service/reads/repair/ReadRepairTest.java
 * src/java/org/apache/cassandra/tools/StandaloneScrubber.java
 * src/java/org/apache/cassandra/service/StorageService.java
 * test/unit/org/apache/cassandra/transport/ClientNotificiationsTest.java
 * test/unit/org/apache/cassandra/schema/MigrationManagerTest.java
 * src/java/org/apache/cassandra/schema/MigrationManager.java
 * src/java/org/apache/cassandra/transport/Server.java
 * test/unit/org/apache/cassandra/hints/HintsReaderTest.java
 * src/java/org/apache/cassandra/metrics/TableMetrics.java
 * src/java/org/apache/cassandra/schema/SchemaPullVerbHandler.java
 * src/java/org/apache/cassandra/schema/SchemaEvent.java
 * test/unit/org/apache/cassandra/io/sstable/IndexSummaryRedistributionTest.java
 * src/java/org/apache/cassandra/db/compaction/CompactionManager.java
 * src/java/org/apache/cassandra/db/SystemKeyspace.java
 * test/distributed/org/apache/cassandra/distributed/action/GossipHelper.java
 * src/java/org/apache/cassandra/db/SchemaCQLHelper.java
 * src/java/org/apache/cassandra/db/SizeEstimatesRecorder.java
 * test/unit/org/apache/cassandra/io/sstable/IndexSummaryManagerTest.java
 * src/java/org/apache/cassandra/schema/SchemaUpdateHandler.java
 * test/unit/org/apache/cassandra/schema/SchemaTest.java
 * src/java/org/apache/cassandra/db/Keyspace.java
 * src/java/org/apache/cassandra/schema/SchemaMigrationEvent.java
 * src/java/org/apache/cassandra/tools/StandaloneVerifier.java
 * 
test/unit/org/apache/cassandra/service/reads/repair/AbstractReadRepairTest.java
 * src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsHolder.java
 * src/java/org/apache/cassandra/schema/SchemaMutationsSerializer.java
 * src/java/org/apache/cassandra/schema/SchemaPushVerbHandler.java
 * test/unit/org/apache/cassandra/db/KeyspaceTest.java
 * test/unit/org/apache/cassandra/cql3/CQLTester.java
 * 
src/java/org/apache/cassandra/cql3/statements/schema/AlterSchemaStatement.java
 * src/java/org/apache/cassandra/cql3/statements/schema/AlterTableStatement.java
 * src/java/org/apache/cassandra/schema/SchemaUpdateHandlerFactory.java
 * test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterClientTest.java
 * test/microbench/org/apache/cassandra/test/microbench/MutationBench.java
 * src/java/org/apache/cassandra/schema/SchemaKeyspace.java
 * 
src/java/org/apache/cassandra/db/commitlog/AbstractCommitLogSegmentManager.java
 * test/unit/org/apache/cassandra/schema/MigrationManagerDropKSTest.java
 * 
test/unit/org/apache/cassandra/cql3/validation/operations/CompactStorageTest.java
 * test/unit/org/apache/cassandra/cql3/validation/entities/TupleTypeTest.java
 * src/java/org/apache/cassandra/auth/AuthSchemaChangeListener.java
 * src/java/org/apache/cassandra/net/Message.java
 * src/java/org/apache/cassandra/cql3/statements/DescribeStatement.java
 * test/unit/org/apache/cassandra/service/PartitionDenylistTest.java
 * src/java/org/apache/cassandra/schema/Schema.java
 * src/java/org/apache/cassandra/io/sstable/CQLSSTableWriter.java

Build Result: UNSTABLE
Passing Tests: 45158
Failing Tests: 21
||Test|Failures|JIRA|
|org.apache.cassandra.cql3.KeywordTest.test[keyword CLUSTERING isReserved 
false]|1 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.ViewComplexDeletionsPartialTest.testPartialDeleteSelectedColumnWithFlush[1]-compression|1
 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest.write_failures_test.TestMultiDCWriteFailures.test_oversized_mutation|5 
of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_parallel_upgrade|1
 of 59|CASSANDRA-17306?|
|dtest-upgrade.upgrade_tests.cql_tests.cls.test_static_cf|2 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.cql3.KeywordTest.test[keyword TIME isReserved false]|1 of 
59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.audit.BinAuditLoggerTest.testSelectRoundTripQuery-compression|1
 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.distributed.test.CasCriticalSectionTest.criticalSectionTest|5
 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade|25
 of 59|CASSANDRA-17306?|
|org.apache.cassandra.distributed.test.ring.BootstrapTest.readWriteDuringBootstrapTest|4
 of 59|[Multiple JIRAs 
found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*BootstrapTest*%22]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade|25
 of 59|CASSANDRA-17306?|
|org.apache.cassandra.cql3.validation.entities.SecondaryIndexTest.testIndexesOnComplexPrimaryKey|1
 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|org.apache.cassandra.distributed.upgrade.MixedModeFrom3UnloggedBatchTest.testSimpleStrategy|1
 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|junit.framework.TestSuite.org.apache.cassandra.distributed.test.CASMultiDCTest|2
 of 59|[Multiple JIRAs 
found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*test*%22]|
|dtest-novnode.write_failures_test.TestMultiDCWriteFailures.test_oversized_mutation|5
 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_parallel_upgrade_with_internode_ssl|3
 of 59|CASSANDRA-17306?|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV4Upgrade_AllVersions_RandomPartitioner_EndsAt_Trunk_HEAD.test_rolling_upgrade_with_internode_ssl|1
 of 59|CASSANDRA-17299?|
|org.apache.cassandra.distributed.test.ReadRepairQueryTypesTest.testRangeQueryWithLimitOnWideTable[8:
 strategy=NONE coordinator=1 flush=false paging=false]|1 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-offheap.write_failures_test.TestMultiDCWriteFailures.test_oversized_mutation|5
 of 59|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade_with_internode_ssl|24
 of 59|CASSANDRA-17306?|
|dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade_with_internode_ssl|24
 of 59|CASSANDRA-17306?|

> Refactor schema management to allow for schema source pluggability
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-17044
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17044
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Cluster/Schema
>            Reporter: Jacek Lewandowski
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>             Fix For: 4.1
>
>
> The idea is decompose `Schema` into separate entities responsible for 
> different things. In particular extract what is related to schema storage and 
> synchronization into a separate class so that it is possible to create an 
> extension point there and store schema in a different way than 
> `system_schema` keyspace, for example in etcd. 
> This would also simplify the logic and reduce the number of special cases, 
> make all the things more testable and the logic of internal classes 
> encapsulated.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to