[ 
https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509029#comment-17509029
 ] 

Stefan Miklosovic commented on CASSANDRA-17448:
-----------------------------------------------

[~brandon.williams]  I dont think this is a good idea. Hear me out please.

Currently, users do not set this variable (CQL_HISTORY) and CQL history written 
to cqlsh_history file. If we control wether history should be written to a file 
or not, from 4.1 onwards, effectively, users will not have any history 
persisted without setting that variable first. So we go from "by default 
writing history" to "by default do not write history". Is this really something 
we want? I think it is pretty inconvenient to suddenly not have history written.

> allow users to change cqlsh history location using env variable
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-17448
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17448
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Interpreter
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 4.1
>
>
> User on GH sent:
> I just started using cassandra and found that it creates history folder in my 
> home directory. I personally don't like it and all my folders follow XDG 
> standard. I found stackoverflow question related to it which says that it's 
> not possible to do without configuring source code of cqlsh.py.
> In this pull request I added a feature to choose history directory using 
> environment variable. The name of variable is CQL_HISTORY. Why ? Because 
> postgres and node-repl use approximately the same convention 
> (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to