[ https://issues.apache.org/jira/browse/CASSANDRA-17252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Meredith updated CASSANDRA-17252: ------------------------------------- Status: Ready to Commit (was: Review In Progress) Starting commit CI Results (pending): ||Branch||Source||Circle CI||Jenkins|| |cassandra-3.0|[branch|https://github.com/jonmeredith/cassandra/tree/commit_remote_branch/CASSANDRA-17252-cassandra-3.0-D9AE02F1-3571-40CD-ACDC-7FA701325BEB]|[build|https://app.circleci.com/pipelines/github/jonmeredith/cassandra?branch=commit_remote_branch%2FCASSANDRA-17252-cassandra-3.0-D9AE02F1-3571-40CD-ACDC-7FA701325BEB]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1519/]| |cassandra-3.11|[branch|https://github.com/jonmeredith/cassandra/tree/commit_remote_branch/CASSANDRA-17252-cassandra-3.11-D9AE02F1-3571-40CD-ACDC-7FA701325BEB]|[build|https://app.circleci.com/pipelines/github/jonmeredith/cassandra?branch=commit_remote_branch%2FCASSANDRA-17252-cassandra-3.11-D9AE02F1-3571-40CD-ACDC-7FA701325BEB]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1520/]| |cassandra-4.0|[branch|https://github.com/jonmeredith/cassandra/tree/commit_remote_branch/CASSANDRA-17252-cassandra-4.0-D9AE02F1-3571-40CD-ACDC-7FA701325BEB]|[build|https://app.circleci.com/pipelines/github/jonmeredith/cassandra?branch=commit_remote_branch%2FCASSANDRA-17252-cassandra-4.0-D9AE02F1-3571-40CD-ACDC-7FA701325BEB]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1521/]| |trunk|[branch|https://github.com/jonmeredith/cassandra/tree/commit_remote_branch/CASSANDRA-17252-trunk-D9AE02F1-3571-40CD-ACDC-7FA701325BEB]|[build|https://app.circleci.com/pipelines/github/jonmeredith/cassandra?branch=commit_remote_branch%2FCASSANDRA-17252-trunk-D9AE02F1-3571-40CD-ACDC-7FA701325BEB]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1522/]| > ConnectionLimitHandler may leaks connection count if remote connection drops > ---------------------------------------------------------------------------- > > Key: CASSANDRA-17252 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17252 > Project: Cassandra > Issue Type: Bug > Components: Messaging/Client > Reporter: Jon Meredith > Assignee: Jon Meredith > Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x > > > In some cases, Netty does not return the original IP used for per-IP counting > when the channel becomes inactive, > which throws an NPE before decrementing the active per-IP count. > {code:java} > java.lang.NullPointerException > at > org.apache.cassandra.transport.ConnectionLimitHandler.channelInactive(ConnectionLimitHandler.java:101) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248) > at > io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241) > at > io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:389) > at > io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:354) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248) > at > io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241) > at > io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1405) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248) > at > io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:901) > at > io.netty.channel.AbstractChannel$AbstractUnsafe$8.run(AbstractChannel.java:819) > at > io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) > at > io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) > at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:497) > at > io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) > at > io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) > at > io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) > at java.base/java.lang.Thread.run(Thread.java:834) > {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org