[
https://issues.apache.org/jira/browse/CASSANDRA-16895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509143#comment-17509143
]
Ekaterina Dimitrova edited comment on CASSANDRA-16895 at 3/19/22, 2:37 AM:
---------------------------------------------------------------------------
Short update:
The bytebuddy issue was solved. I realized I have to update mockito which was
dependent on an old version of bytebuddy.
After update this is the latest CI run for Java 17:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1481/workflows/9f065c12-4c3d-4d6e-b9fc-ee4eb8c5f38b]
*CQLSH tests:*
* test_round_trip_random is failing with vnodes due to
{code:java}
Exception encountered during startup: The number of initial tokens (by
initial_token) specified (0) is different from num_tokens value (16){code}
Sounds weird, have to investigate it
*DTests:*
* test_oversized_mutation - known failure on trunk
* test_sjk - I just noticed we need to start Cassandra with _--add-exports
jdk.attach/sun.tools.attach=ALL-UNNAMED_ and then SJK works fine. Also, I
updated the SJK to the latest version
* There are 4 UDF functions I broke, please, ignore for now; just noise at
this point
* test_archiving_fql, test_archiving and test_fql_nodetool_options fail for
the same reason - a warning in the logs
{code:java}
Slf4jExceptionHandler.java:38 - Failed to shrink file as it exists no
longer{code}
I haven't had the chance to look at this one yet.
* test_batch_and_slice - fails with
{code:java}
Batch too large{code}
This also needs to be investigated
* test_failing_manual_rebuild_index - to be investigated
* test_hintedhandoff_window - I think this is a known issue
*JVM tests:*
* InternodeEncryptionOptionsTest - all failing if we run them together, but
locally when I run them separately
negotiatedProtocolMustBeAcceptedProtocolTest and
allInternodeEncryptionEstablishedTest are the only two failing in that class.
On a quick glance I think they were trying to use TLSv1 which as
[~maulin.vasavada] already mentioned is disabled in Java 17. To be checked
* bulkLoaderSuccessfullyStreamsOverSsl - to be checked; I guess could be again
the TLSv1
* testPreparedBatch, testReprepareNewBehaviour, testUseWithMultipleKeyspaces,
testReprepareTwoKeyspacesNewBehaviour, fuzzTest, startupNewIP,
sameIPFailWithoutReplace, sameIPFailWithoutReplace, mixedModeFuzzTest - all of
them hit CASSANDRA-16304; course of action TBD next week
* noWarningsSinglePartition, noWarningsScan - to be investigated
*Unit tests:*
* a few scripted UDF related tests, to be ignored
* EmptyValuesTest - the whole class; to be investigated
* testNoTreesRetainedAfterDifference - this one is really hungry for more and
more --add-opens....I already opened a lot... to be checked further
* testTruncationReleasesLogSpace - this also needs more --add-opens
* testReplace - to be investigated
-------
*To summarize -*
* 1 CQLSH python DTest
* 7 DTests failing (1 known fix and 3 failing for one and the same reason)
* 14 JVM tests – 3 probably TLSv1?, 9 because of CASSANDRA-16304
* 4 Unit tets - 2 of them probably just require more add-opens.
I have to take care of Jenkins, some adjustments around Java 11 upgrade tests
as up to now we were running them with Java 8
And I am wondering whether we don't want a feature branch for this one. Also, I
will be looking for reviewers at some point. Anyone interested to test how
things are going, just ping me on Slack
was (Author: e.dimitrova):
Short update:
The bytebuddy issue was solved. I realized I have to update mockito which was
dependent on an old version of bytebuddy.
After update this is the latest CI run for Java 17:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1481/workflows/9f065c12-4c3d-4d6e-b9fc-ee4eb8c5f38b]
*CQLSH tests:*
* test_round_trip_random is failing with vnodes due to
{code:java}
Exception encountered during startup: The number of initial tokens (by
initial_token) specified (0) is different from num_tokens value (16){code}
Sounds weird, have to investigate it
*DTests:*
* test_oversized_mutation - known failure on trunk
* test_sjk - I just noticed we need to start Cassandra with _--add-exports
jdk.attach/sun.tools.attach=ALL-UNNAMED_ and then SJK works fine. Also, I
updated the SJK to the latest version
* There are 4 UDF functions I broke, please, ignore for now; just noise at
this point
* test_archiving_fql, test_archiving and test_fql_nodetool_options fail for
the same reason - a warning in the logs
{code:java}
Slf4jExceptionHandler.java:38 - Failed to shrink file as it exists no
longer{code}
I haven't had the chance to look at this one yet.
* test_batch_and_slice - fails with
{code:java}
Batch too large{code}
This also needs to be investigated
* test_failing_manual_rebuild_index - to be investigated
* test_hintedhandoff_window - I think this is a known issue
*JVM tests:*
* InternodeEncryptionOptionsTest - all failing if we run them together, but
locally when I run them separately
negotiatedProtocolMustBeAcceptedProtocolTest and
allInternodeEncryptionEstablishedTest are the only two failing in that class.
On a quick glance I think they were trying to use TLSv1 which as
[~maulin.vasavada] already mentioned is disabled in Java 17. To be checked
* bulkLoaderSuccessfullyStreamsOverSsl - to be checked; I guess could be again
the TLSv1
* testPreparedBatch, testReprepareNewBehaviour, testUseWithMultipleKeyspaces,
testReprepareTwoKeyspacesNewBehaviour, fuzzTest, startupNewIP,
sameIPFailWithoutReplace, sameIPFailWithoutReplace, mixedModeFuzzTest - all of
them hit CASSANDRA-16304; course of action TBD next week
* noWarningsSinglePartition, noWarningsScan - to be investigated
*Unit tests:*
* a few scripted UDF related tests, to be ignored
* EmptyValuesTest - the whole class; to be investigated
* testNoTreesRetainedAfterDifference - this one is really hungry for more and
more --add-opens....I already opened a lot... to be checked further
* testTruncationReleasesLogSpace - this also needs more --add-opens
* testReplace - to be investigated
-------
*To summarize -*
* 1 CQLSH python DTest
* 7 DTests failing (1 known fix and 3 failing for one and the same reason)
* 14 JVM tests – 3 probably TLSv1?, 9 because of CASSANDRA-16304
* 4 Unit tets - 2 probably just require more add-opens.
I have to take care of Jenkins, some adjustments around Java 11 upgrade tests
as up to now we were running them with Java 8
And I am wondering whether we don't want a feature branch for this one. Also, I
will be looking for reviewers at some point. Anyone interested to test how
things are going, just ping me on Slack
> Support Java 17
> ---------------
>
> Key: CASSANDRA-16895
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16895
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
>
> This ticket is intended to group all issues found to support Java 17 in the
> future.
> Upgrade steps:
> * [Dependencies
> |https://mvnrepository.com/artifact/org.apache.cassandra/cassandra-all/4.0.1]to
> be updated (not all but at least those that require an update in order to
> work with Java 17)
> * More encapsulated JDK internal APIs. Some of the issues might be solved
> with the dependencies updates
> * Currently trunk compiles if we remove the Nashorn dependency (ant script
> tag, used for the test environment; UDFs) . The oracle recommendation to use
> Nashorn-core won't work for the project as it is under GPL 2.0. Most probably
> we will opt in for graal-sdk licensed under UPL
> * All tests to be cleaned
> * CI environment to be setup
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
