[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511947#comment-17511947
]
David Capwell commented on CASSANDRA-17332:
-------------------------------------------
bq. in theory, there should be nothing that prevents to have one node using
multiple tokens, and the other just one. Should we have vnodes as a
cluster-wide setting, or should we just allow setting an arbitrary number of
tokens?
Thats possible now with this patch, but not the cleanest API. So, assuming all
nodes have > 1 token then we respect the token count the test wants rather than
use the global setting, we only rely on the global setting here to know if the
test should be skipped or not.
Now, if you want to test some nodes having 1 token and others having > 1
token... this won't ever run as we will skip; if this edge case needs to be
handled, the skip logic needs more work.
bq. enable/disable vnodes: void withVNodes void withoutVNodes
I can send a PR to dtest-api. Right now we only care about withoutVNodes, so
not sure if we should have withVNodes or what it would do
bq. It would be good to add some basic tests for the initial_token override
logic, and token count: when the test should succeed and when fail.
Will look into testing
> Add support for vnodes in jvm-dtest
> -----------------------------------
>
> Key: CASSANDRA-17332
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17332
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Labels: pull-request-available
> Fix For: 4.x
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Right now python dtests need to keep running after being ported to jvm-dtests
> as vnode support is not present, to fully deprecate the python dtests, we
> need vnode support in jvm-dtest.
> Sadly, to add support we need to break binary compatibility, but can maintain
> source compatibility… so will need to bump every jar across every branch
> (mostly due to TokenSupplier)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
