[
https://issues.apache.org/jira/browse/CASSANDRA-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512304#comment-17512304
]
Berenguer Blasi commented on CASSANDRA-17140:
---------------------------------------------
This is what I've found so far:
- Dirty reverting 15252 on 4.0
[fixes|https://app.circleci.com/pipelines/github/bereng/cassandra/628/workflows/59274d2f-8346-4d53-8e69-c7d4cf2a5080]
50% of these tests. The other non-upgrade failures seem related to the revert
itself and I don't think it adds any new significant failures.
- The other upgrade 50% failures seems to pass locally if I also dirty revert
3.11. That makes sense as being an upgrade test both versions need to be on the
same page regarding pstmnts UUIDS.
- Seems like a dirty revert would fix these and not introduce new failures but
would obviously resuscitate 15252's original bug.
This means we have an option to dirty revert, which I am not fully aware of the
consequences and it's also quite involved. The other option is to deep dive
into 15252 and try to fix it properly. I'll let this simmer during the weekend
but I guess the best would be to revert until sbdy has bandwidth to tackle a
fix for 15252. I would ask first to the 15252's authors if they see a problem
with this or if they want to try a fix first.
Who'd be willing to be a reviewer here?
> Broken test_rolling_upgrade -
> upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_3_0_x_To_indev_4_0_x
> ----------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17140
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Yifan Cai
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0.x
>
>
> The tests "test_rolling_upgrade" fail with the below error.
>
> [https://app.circleci.com/pipelines/github/yifan-c/cassandra/279/workflows/6340cd42-0b27-42c2-8418-9f8b56c57bea/jobs/1990]
>
> I am able to alway produce it by running the test locally too.
> {{$ pytest --execute-upgrade-tests-only --upgrade-target-version-only
> --upgrade-version-selection all --cassandra-version=4.0
> upgrade_tests/upgrade_through_versions_test.py::TestUpgrade_indev_3_11_x_To_indev_4_0_x::test_rolling_upgrade}}
>
> {code:java}
> self =
> <upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_3_0_x_To_indev_4_0_x
> object at 0x7ffba4242fd0>
> subprocs = [<Process(Process-1, stopped[SIGKILL] daemon)>,
> <Process(Process-2, stopped[1] daemon)>]
> def _check_on_subprocs(self, subprocs):
> """
> Check on given subprocesses.
>
> If any are not alive, we'll go ahead and terminate any remaining
> alive subprocesses since this test is going to fail.
> """
> subproc_statuses = [s.is_alive() for s in subprocs]
> if not all(subproc_statuses):
> message = "A subprocess has terminated early. Subprocess
> statuses: "
> for s in subprocs:
> message += "{name} (is_alive: {aliveness}),
> ".format(name=s.name, aliveness=s.is_alive())
> message += "attempting to terminate remaining subprocesses now."
> self._terminate_subprocs()
> > raise RuntimeError(message)
> E RuntimeError: A subprocess has terminated early. Subprocess
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting
> to terminate remaining subprocesses now.{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
