[
https://issues.apache.org/jira/browse/CASSANDRA-17443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513931#comment-17513931
]
Berenguer Blasi commented on CASSANDRA-17443:
---------------------------------------------
Aha! right. I was looking for the {{CommitLogTest}} runs, to confirm it wasn't
actually run, and it said skipped but I missed it was abstract. Yes I can see
that missing test being ran now where it wasn't before. Looking at the history
I think this was unintentionally disabled as well. Also CI passes so LGTM +1
> testUnwriteableFlushRecovery is never called
> --------------------------------------------
>
> Key: CASSANDRA-17443
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17443
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
> Reporter: Ruslan Fomkin
> Assignee: Ruslan Fomkin
> Priority: Normal
> Labels: test
>
> `testUnwriteableFlushRecovery` of `CommitLogTest` was implemented 6 years ago
> and seems to became a dead code immediately. It should be either enabled back
> or removed. The source of the test is at
> https://github.com/apache/cassandra/blob/2b2c6decfafc6235ad537e72073fab2fd4467e2f/test/unit/org/apache/cassandra/db/commitlog/CommitLogTest.java#L932
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
