[ 
https://issues.apache.org/jira/browse/CASSANDRA-17140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517310#comment-17517310
 ] 

Berenguer Blasi commented on CASSANDRA-17140:
---------------------------------------------

[~ifesdjeen] thx a lot for the feedback!

The root problem is that coming to the ticket with a blank sheet of paper it is 
just a cross-roads where every road looks just like the other bc lack of 
context: Is it a legit bug? is it ok to revert? what would reverting break? Is 
it reasonable avoiding the usage of {{USE}}? Is a retry a valid option?... It's 
a lot of work (and duplication) having to find out all that by oneself, whereas 
sbdy that has worked on the ticket can probably answer which path to 
investigate and which one to not look into. I was seeing the trees but not the 
forest.

Having said that now I have sthg to work with which is looking good locally. 
Fingers crossed and thx again!

> Broken test_rolling_upgrade - 
> upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_3_0_x_To_indev_4_0_x
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Yifan Cai
>            Assignee: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.0.x
>
>
> The tests "test_rolling_upgrade" fail with the below error. 
>  
> [https://app.circleci.com/pipelines/github/yifan-c/cassandra/279/workflows/6340cd42-0b27-42c2-8418-9f8b56c57bea/jobs/1990]
>  
> I am able to alway produce it by running the test locally too. 
> {{$ pytest --execute-upgrade-tests-only --upgrade-target-version-only 
> --upgrade-version-selection all --cassandra-version=4.0 
> upgrade_tests/upgrade_through_versions_test.py::TestUpgrade_indev_3_11_x_To_indev_4_0_x::test_rolling_upgrade}}
>  
> {code:java}
> self = 
> <upgrade_tests.upgrade_through_versions_test.TestUpgrade_indev_3_0_x_To_indev_4_0_x
>  object at 0x7ffba4242fd0>
> subprocs = [<Process(Process-1, stopped[SIGKILL] daemon)>, 
> <Process(Process-2, stopped[1] daemon)>]
>     def _check_on_subprocs(self, subprocs):
>         """
>             Check on given subprocesses.
>     
>             If any are not alive, we'll go ahead and terminate any remaining 
> alive subprocesses since this test is going to fail.
>             """
>         subproc_statuses = [s.is_alive() for s in subprocs]
>         if not all(subproc_statuses):
>             message = "A subprocess has terminated early. Subprocess 
> statuses: "
>             for s in subprocs:
>                 message += "{name} (is_alive: {aliveness}), 
> ".format(name=s.name, aliveness=s.is_alive())
>             message += "attempting to terminate remaining subprocesses now."
>             self._terminate_subprocs()
> >           raise RuntimeError(message)
> E           RuntimeError: A subprocess has terminated early. Subprocess 
> statuses: Process-1 (is_alive: True), Process-2 (is_alive: False), attempting 
> to terminate remaining subprocesses now.{code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to