[ 
https://issues.apache.org/jira/browse/CASSANDRA-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530151#comment-17530151
 ] 

Ekaterina Dimitrova commented on CASSANDRA-17582:
-------------------------------------------------

[~ifesdjeen] , [~jlewandowski] is not a committer yet so we have to commit this 
one for him.

He just rebased and ran CI here so I can help commit - 
[https://app.circleci.com/pipelines/github/jacek-lewandowski/cassandra/220/workflows/aeb85ab4-c69a-45c8-82ec-f810949d1317]

 

There is one new failure but I don't see how this patch can cause it. There 
were a lot of works committed before the freeze in the past two days. Anyway I 
am looping the test with latest trunk and the patch and I will commit after 
that if nothing proves me wrong in my judgement.

Trunk run:

[j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1575/workflows/f9409df6-825f-4996-976a-0182549d87dc/jobs/10405]

Patch run:

 
[j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1574/workflows/86dad3ef-e9c7-424f-9da9-ec22871d6588/jobs/10404]

> Add missing information about whether to drop sstables or not when dropping 
> schema objects
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17582
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/SSTable
>            Reporter: Jacek Lewandowski
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>             Fix For: 4.x
>
>
> This is the missed piece in SchemaChangeListener - when the implementation of 
> SchemaUpdateHandler decides to say drop a table but keep sstables, that 
> information about not-dropping sstables is not propagated to the 
> SchemaChangeListener



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to