[ 
https://issues.apache.org/jira/browse/CASSANDRA-16843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530243#comment-17530243
 ] 

Paulo Motta edited comment on CASSANDRA-16843 at 4/29/22 9:01 PM:
------------------------------------------------------------------

{quote}listsnapshots gives me "Total TrueDiskSpaceUsed: 0 bytes" irrelevant how 
many snapshots I have
{quote}

*Total* true disk space (which is different from "true disk space" of 
individual snapshots) is zero because all sstables are live, so snapshots are 
not taking any extra space.

This is working as expected. It's the current behavior on trunk and it is not 
changed by this patch.

However there is another bug there, because "Total TrueDiskSpaceUsed" should 
include sizes of schema and manifest files.

I do not touch the code path that is responsible for computing "{*}Total{*} 
TrueDiskSpaceUsed" on this patch. The true disk space should also include 
manifest and schema files, but fixing that requires a reworking of how the 
*total* true size is computed, and is out of the scope of this patch.

I fixed this on the extended version of this patch that will be posted later.


was (Author: paulo):
{quote}listsnapshots gives me "Total TrueDiskSpaceUsed: 0 bytes" irrelevant how 
many snapshots I have
{quote}

True disk space is zero because all sstables are live, so snapshots are not 
taking any extra space.

This is working as expected. It's the current behavior on trunk and it is not 
changed by this patch. 

However there is another bug there, because "Total TrueDiskSpaceUsed" should 
include sizes of schema and manifest files.

I do not touch the code path that is responsible for computing "*Total* 
TrueDiskSpaceUsed" on this patch. The true disk space should also include 
manifest and schema files, but fixing that requires a reworking of how the 
*total* true size is computed, and is out of the scope of this patch. 

I fixed this on the extended version of this patch that will be posted later.

> List snapshots of dropped tables
> --------------------------------
>
>                 Key: CASSANDRA-16843
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16843
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Snapshots
>            Reporter: James Brown
>            Assignee: Paulo Motta
>            Priority: Normal
>             Fix For: 4.1
>
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> Auto snapshots from dropped tables don't seem to show up in {{nodetool 
> listsnapshots}} (even though they do get cleared by {{nodetool 
> clearsnapshot}}). This makes them kind of annoying to clean up, since you 
> need to muck about in the data directory to find them.
> Erick on the mailing list said that this seems to be an oversight and that 
> clearsnapshot was fixed by 
> [CASSANDRA-6418|https://issues.apache.org/jira/browse/CASSANDRA-6418].
> I reproduced this both on 3.11.11 and 4.0.0.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to