[
https://issues.apache.org/jira/browse/CASSANDRA-17596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532069#comment-17532069
]
Berenguer Blasi commented on CASSANDRA-17596:
---------------------------------------------
LGTM at face value as a null start/end does make much sense imo. But I'd wait
for sbdy else with more knowledge in that area to confirm. Also we'd need CI
runs for the other branches before the merge imo. #my2cts :-)
> Fix NPE in SimpleBuilders.ParititionUpdateBulder.RTBuilder.build
> ----------------------------------------------------------------
>
> Key: CASSANDRA-17596
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17596
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Core
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.1, 4.0.5, 4.x
>
>
> These two arrays are not initialised (1) which means that if I do not set
> start nor end, when ClusteringBound.create is called, it will be null, but it
> will fail here (2) as values will be null.
> The fix consists of check if values are null and if they are, we build that
> bound immediately.
> (1)
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/SimpleBuilders.java#L257-L258
> (2)
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/ClusteringBound.java#L128
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
