[
https://issues.apache.org/jira/browse/CASSANDRA-17593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533618#comment-17533618
]
Berenguer Blasi commented on CASSANDRA-17593:
---------------------------------------------
Overall approach with nullable annotations etc lgmt and I dropped a few
comments. But CI has many failures, probably related to the hints service stop,
let's hope it's a quick one to fix :-)
> StorageService read threshold get methods throw NullPointerException due to
> not handling null configs
> -----------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17593
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17593
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/JMX
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 4.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> org.apache.cassandra.service.StorageService#getCoordinatorLargeReadWarnThreshold
> and other similar get methods touch the following null configs
> {code}
> public volatile DataStorageSpec coordinator_read_size_warn_threshold = null;
> public volatile DataStorageSpec coordinator_read_size_fail_threshold = null;
> public volatile DataStorageSpec local_read_size_warn_threshold = null;
> public volatile DataStorageSpec local_read_size_fail_threshold = null;
> public volatile DataStorageSpec row_index_read_size_warn_threshold = null;
> public volatile DataStorageSpec row_index_read_size_fail_threshold = null
> {code}
> Null is a valid state for these configs, so null must be handled in the get
> methods; they currently are not and throw NullPointerException when accessed
> via JMX
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
