[
https://issues.apache.org/jira/browse/CASSANDRA-17605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534331#comment-17534331
]
Andres de la Peña commented on CASSANDRA-17605:
-----------------------------------------------
Thinking it again, it might be a better idea to just increase the TTLs and use
the {{@flaky}} annotation to just repeat the test a number of times until it
succeeds. We could keep the current catching of exceptions and time check to
throw a custom exception when the checks fail due to a slow environment. Then
we would use a
[{{rerun_filter}}|https://github.com/box/flaky/blob/master/flaky/flaky_decorator.py#L18-L30]
to only repeat the test if it has failed in the expected conditions, similarly
to what is done with
[{{test_failure_due_to_timeout}}|https://github.com/apache/cassandra-dtest/blob/trunk/dtest.py#L202-L231].
That way we would be giving more time to the slow environment instead of just
skipping the tests. wdyt?
> Fix
> dtest-offheap.materialized_views_test.TestMaterializedViews.test_mv_with_default_ttl_with_flush
> ---------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17605
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17605
> Project: Cassandra
> Issue Type: Bug
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Berenguer Blasi
> Priority: Urgent
> Fix For: 4.1.x
>
>
> h3.
> https://ci-cassandra.apache.org/job/Cassandra-4.1/5/testReport/dtest-offheap.materialized_views_test/TestMaterializedViews/test_mv_with_default_ttl_with_flush_2/
> {code:java}
> Error Message
> AssertionError: Expected [[1, 6, 1]] from SELECT * FROM t, but got [[1, None,
> 1]]
> Stacktrace
> self = <materialized_views_test.TestMaterializedViews object at
> 0x7f8b1fd21cd0> @since('3.0') def test_mv_with_default_ttl_with_flush(self):
> > self._test_mv_with_default_ttl(True) materialized_views_test.py:1320: _ _ _
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> materialized_views_test.py:1416: in _test_mv_with_default_ttl
> assert_one(session, "SELECT * FROM t", [1, 6, 1]) _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ session =
> <cassandra.cluster.Session object at 0x7f8b1f167f70> query = 'SELECT * FROM
> t', expected = [1, 6, 1], cl = None def assert_one(session, query, expected,
> cl=None): """ Assert query returns one row. @param session Session to use
> @param query Query to run @param expected Expected results from query @param
> cl Optional Consistency Level setting. Default ONE Examples:
> assert_one(session, "LIST USERS", ['cassandra', True]) assert_one(session,
> query, [0, 0]) """ simple_query = SimpleStatement(query,
> consistency_level=cl) res = session.execute(simple_query) list_res =
> _rows_to_list(res) > assert list_res == [expected], "Expected {} from {}, but
> got {}".format([expected], query, list_res) E AssertionError: Expected [[1,
> 6, 1]] from SELECT * FROM t, but got [[1, None, 1]] tools/assertions.py:132:
> AssertionError
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
