[ 
https://issues.apache.org/jira/browse/CASSANDRA-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534576#comment-17534576
 ] 

Brandon Williams commented on CASSANDRA-17617:
----------------------------------------------

We don't have any for timing, and I don't think this is the juncture to add 
one.  Since functionality didn't change and this is a trivial patch I think a 
clean CI run is enough.  To that end...

||Branch||CI||
|[3.11|https://github.com/driftx/cassandra/tree/CASSANDRA-17617-3.11]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/463/workflows/6b9d2f12-d8a9-4aad-bf94-7a4d5e68ac2f]|
|[4.0|https://github.com/driftx/cassandra/tree/CASSANDRA-17617-4.0]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/466/workflows/b2805839-bb07-4dc5-8086-b19394950a7d],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/466/workflows/938460fb-e637-40a3-91c3-20e87912e587]|
|[4.1|https://github.com/driftx/cassandra/tree/CASSANDRA-17617-4.1]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/464/workflows/b6ac6245-9de2-4e34-9df8-d4f7a46b9b5d],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/464/workflows/87f1b9c1-43cb-4982-9741-dbba158e1a47]|
|[trunk|https://github.com/driftx/cassandra/tree/CASSANDRA-17617-trunk]|[j8|https://app.circleci.com/pipelines/github/driftx/cassandra/465/workflows/4dd2b1d2-3383-4d7e-9ebe-faade124188e],
 
[j11|https://app.circleci.com/pipelines/github/driftx/cassandra/465/workflows/f5f95d87-e44f-4f43-a3fd-d80b0f5d8b36]|



> CQLSH unicode control character list is too liberal
> ---------------------------------------------------
>
>                 Key: CASSANDRA-17617
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17617
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Interpreter
>            Reporter: Tanuj Nayak
>            Assignee: Tanuj Nayak
>            Priority: Normal
>             Fix For: 3.11.x, 4.0.x, 4.1.x
>
>
> It appears that the list of escaped unicode control characters 
> [here|https://github.com/apache/cassandra/blob/53a67ff2c36d90d337aba1409498de29931d4279/pylib/cqlshlib/formatting.py#L32]
>  is a bit too liberal. It seems to include characters such as '1' (0x31) and 
> '0' (0x30) which do not need to be escaped. It seems that the actual range 
> should be 0x00 - 0x1F and 0x7F+ as corroborated [by this 
> page|https://en.wikipedia.org/wiki/Unicode_control_characters].
>  
> This causes unnecessary escaping and regex substitutions on the CQLSH end 
> whenever common characters such as any punctuation or a 0 or a 1 appear in 
> the text column of a table. One might notice that a table with a text column 
> filled with 2's will take much less time to print than one with all 0's for 
> this reason.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to