[
https://issues.apache.org/jira/browse/CASSANDRA-17638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ekaterina Dimitrova updated CASSANDRA-17638:
--------------------------------------------
Test and Documentation Plan:
||PR||CI||
|[4.1|https://github.com/ekaterinadimitrova2/cassandra/pull/200]|[j8,|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1629/workflows/8cdc3a89-9f63-4395-8964-03a954f93f37]
[j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1629/workflows/675d33aa-8c67-4f85-b22b-ad425a004a02]|
|[trunk|https://github.com/ekaterinadimitrova2/cassandra/pull/201]|[j8,|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1630/workflows/a57aaea3-2ec9-4c34-9347-9e8679ecfecd]
[j11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1630/workflows/e7bca094-523c-492a-a0cc-5ea7b628e01c]|
The current tests.
While fixing the exceptions I noticed we didn't remove a validation not needed
anymore which makes just an additional empty read of the cassandra.yaml without
a need anymore. I did it in this
[commit|https://github.com/apache/cassandra/commit/8f0685da22596fe88dc87186ea5e2b673c3613ab].
Some context:
IsBlank is redundant when we have commitlog_sync_period and
commitlog_sync_group_window default to 0ms and not 0, that was enough to
prevent from the issue with allowing empty value in the yaml
I added a new test to confirm we didn't break anything. Unfortunately, the test
failed in CI as I didn't commit the last fix I had for it.I added the commit
now but not rerunning full CI for that one. There are two other tests with
known unrelated failures.
Status: Patch Available (was: In Progress)
> Clients using JMX are unable to handle non-standard java types but we leak
> this into our Exceptions
> ---------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17638
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17638
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability, Observability/JMX
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> This is follow up ticket on CASSANDRA-17527 and CASSANDRA-17580.
> CASSANDRA-17580 was decided to be a backup non-default option for users who
> want to be 100% sure there are no leaked Cassandra exceptions. In that sense
> I will fix here all known ConfigurationExceptions that need to be thrown as
> IllegalArgumentException for the default behavior as we were always supposed
> to do that.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
