[ 
https://issues.apache.org/jira/browse/CASSANDRA-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540479#comment-17540479
 ] 

Stefan Miklosovic edited comment on CASSANDRA-17619 at 5/21/22 6:13 PM:
------------------------------------------------------------------------

[~paulo] I ve run one more circle job for 4.1 with rebased stuff and this is 
what I got. Check the first failed test there. It can not load snapshots as 
there is "no file found exception". I am not completely sure about the anatomy 
of that test yet but this is quite weird that we are getting this exception.

I think it is just flaky as locally it just went fine.

It seems like we were about to load the snapshots and it was walking the tree 
but all of sudden these files were deleted under its hands.

[https://app.circleci.com/pipelines/github/instaclustr/cassandra/976/workflows/1fd26858-c5ad-44f3-bab3-2318da3bd729/jobs/4226/tests]


was (Author: smiklosovic):
[~paulo] I ve run one more circle job for 4.1 with rebased stuff and this is 
what I got. Check the first failed test there. It can not load snapshots as 
there is "no file found exception". I am not completely sure about the anatomy 
of that test yet but this is quite weird that we are getting this exception.

I think it is just flaky as locally it just went fine.

https://app.circleci.com/pipelines/github/instaclustr/cassandra/976/workflows/1fd26858-c5ad-44f3-bab3-2318da3bd729/jobs/4226/tests

> Expired snapshots of dropped tables are not removed after node restart
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-17619
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17619
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Snapshots
>            Reporter: Paulo Motta
>            Assignee: Paulo Motta
>            Priority: Normal
>             Fix For: 4.1-beta
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Expired TTL snapshots from a dropped table are only removed if the node is 
> not restarted after the table is dropped.
> The reason for this is because {{SnapshotManager}} is using the old 
> implementation of {{listsnapshots}} to load snapshots in memory during node 
> startup, before CASSANDRA-16843 is fixed so it doesn't keep track of 
> snapshots of dropped tables.
> We should make {{SnapshotManager}} use the new implementation to load 
> snapshots of dropped tables in memory, what ensures they will be removed when 
> expired.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to