[
https://issues.apache.org/jira/browse/CASSANDRA-17650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556579#comment-17556579
]
Ekaterina Dimitrova commented on CASSANDRA-17650:
-------------------------------------------------
PR is enough. Normally we set the ticket to Patch Available or Need Committer
to signal the ticket is ready for review.
I went back to the original ticket mentioned in the description -
CASSANDRA-15470, further to looking for the validations existence. It is stated
that the check is added for those properties which are not widened to long.
It seems to me that getBatchSizeFailThreshold returns long and that is why the
validation was not added.
It is a bit confusing as now some properties are checked for overflow, others
are widened. I don't think we should change that as Long.MAX_VALUE is bigger
than Integer.MAX_VALUE*1024 and this will mean we will cap the max to a lower
number and thus introduce a bug. The check makes sense where int is returned by
the getter in bytes as then we have the potential for overflow in bytes.
On the other hand I see in your PR you fixed the DatabaseDescriptorTest line
329 which is valid and I think we should commit that part. Good catch, thanks.
[~adelapena], do you mind to review this too? I believe we don't need full CI
run for this test fix. I checked it and ran the test locally.
> Check startup and setter validations for batch_size_fail_threshold
> ------------------------------------------------------------------
>
> Key: CASSANDRA-17650
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17650
> Project: Cassandra
> Issue Type: Task
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Akin Tekeoglu
> Priority: Low
> Fix For: 4.0.x, 4.1.x, 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During manual inspection it was noticed that batch_size_warn_threshold goes
> through checkValidForByteConversion, but this is not the case for
> batch_size_fail_threshold.
> This ticket is opened to check whether this is a bug or not.
> If it is confirmed it is a bug it needs to be fixed and the ticket can be
> changed to type bug. It seems that this validation was added as part of
> CASSANDRA-15470 to 4.0+. Maybe we also need it in 3.0 and 3.11?
> CC [~adelapena]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
