[
https://issues.apache.org/jira/browse/CASSANDRA-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557238#comment-17557238
]
Caleb Rackliffe commented on CASSANDRA-6936:
--------------------------------------------
My pass at review is complete, and all comments/nits (none of which amount to
serious pushback) are inline in the PR. I'll officially +1 once those items are
resolved (or reasonably ignored). Nice work!
> Make all byte representations of types comparable by their unsigned byte
> representation only
> --------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-6936
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6936
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
> Reporter: Benedict Elliott Smith
> Assignee: Branimir Lambov
> Priority: Normal
> Labels: compaction, performance
> Fix For: 4.x
>
> Time Spent: 23h 10m
> Remaining Estimate: 0h
>
> This could be a painful change, but is necessary for implementing a
> trie-based index, and settling for less would be suboptimal; it also should
> make comparisons cheaper all-round, and since comparison operations are
> pretty much the majority of C*'s business, this should be easily felt (see
> CASSANDRA-6553 and CASSANDRA-6934 for an example of some minor changes with
> major performance impacts). No copying/special casing/slicing should mean
> fewer opportunities to introduce performance regressions as well.
> Since I have slated for 3.0 a lot of non-backwards-compatible sstable
> changes, hopefully this shouldn't be too much more of a burden.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
