[
https://issues.apache.org/jira/browse/CASSANDRA-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557817#comment-17557817
]
Stefan Miklosovic commented on CASSANDRA-16911:
-----------------------------------------------
I will answer my own question - the answer is no, we should not add all of
them. The reasoning behind that is that once we put it into memory, we
"decouple" it from what is on the disk. So if somebody removes a snapshot
manually from the disk when the node is running (even though snapshot removal
should be done via nodetool), it will become inconsistent with the state in the
memory. Hence any subsequent listing of snapshots will not reflect reality
anymore.
[~paulo] I will prepare the patch in such a way that SnapshotManager will be
without ephemerals and will walk the disk once upon scrubbing and second time
when snapshot manager is about to load the snapshots on ttls.
> Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-16911
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16911
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.2
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> While creating an ephemeral snapshot, a marker file is created at disk in a
> respective snapshot directory. This is not necessary anymore as we have
> introduced SnapshotManifest in CASSANDRA-16789 so we can move this flag
> there. By putting the information if a snapshot is ephemeral or not into
> SnapshotManifest, we simplify and "clean up" the snapshotting process and
> related codebase.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
