[ 
https://issues.apache.org/jira/browse/CASSANDRA-17617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17559257#comment-17559257
 ] 

Josh McKenzie commented on CASSANDRA-17617:
-------------------------------------------

[CI Results]
Branch: 4.1, build number: 68
   butler url: 
https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-4.1/Cassandra-4.1
   jenkins url: https://ci-cassandra.apache.org/job/Cassandra-4.1/68/
   JIRA: CASSANDRA-17617
   commit url: 
https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=f884dda75b1427b8cb9aa64c46d30fb4c1eeffee
   affected paths:
* pylib/cqlshlib/formatting.py

   Build Result: UNSTABLE
   Passing Tests: 47693
   Failing Tests: 8

||Test|Failures|JIRA||
|org.apache.cassandra.cql3.ViewFilteringClustering1Test.testClusteringKeySliceRestrictions[3]|11
 of 65|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]
|org.apache.cassandra.db.monitoring.MonitoringTaskTest.testMultipleThreadsSameNameSlow|2
 of 65|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]
|org.apache.cassandra.distributed.upgrade.BatchUpgradeTest.batchTest|16 of 
65|[CASSANDRA-17651?|https://issues.apache.org/jira/browse/CASSANDRA-17651]|
|org.apache.cassandra.net.proxy.ProxyHandlerTest.testNormalDelivery-cdc|2 of 
65|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]
|org.apache.cassandra.cql3.validation.entities.SecondaryIndexTest.testWithEmptyRestrictionValueAndSecondaryIndex|5
 of 65|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]
|org.apache.cassandra.cql3.validation.entities.TupleTypeTest.testNestedTuple|8 
of 65|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]
|org.apache.cassandra.cql3.ViewFiltering2Test.testRestrictedRegularColumnTimestampUpdates[3]|1
 of 65|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]
|org.apache.cassandra.cql3.ViewFiltering1Test.testFilterWithFunction[3]|1 of 
65|[No JIRA 
found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&quickFilter=2252]

> CQLSH unicode control character list is too liberal
> ---------------------------------------------------
>
>                 Key: CASSANDRA-17617
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17617
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL/Interpreter
>            Reporter: Tanuj Nayak
>            Assignee: Tanuj Nayak
>            Priority: Normal
>             Fix For: 3.11.14, 4.0.5, 4.1-rc, 4.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> It appears that the list of escaped unicode control characters 
> [here|https://github.com/apache/cassandra/blob/53a67ff2c36d90d337aba1409498de29931d4279/pylib/cqlshlib/formatting.py#L32]
>  is a bit too liberal. It seems to include characters such as '1' (0x31) and 
> '0' (0x30) which do not need to be escaped. It seems that the actual range 
> should be 0x00 - 0x1F and 0x7F+ as corroborated [by this 
> page|https://en.wikipedia.org/wiki/Unicode_control_characters].
>  
> This causes unnecessary escaping and regex substitutions on the CQLSH end 
> whenever common characters such as any punctuation or a 0 or a 1 appear in 
> the text column of a table. One might notice that a table with a text column 
> filled with 2's will take much less time to print than one with all 0's for 
> this reason.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to