[
https://issues.apache.org/jira/browse/CASSANDRA-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567373#comment-17567373
]
Ekaterina Dimitrova commented on CASSANDRA-17725:
-------------------------------------------------
I just rebased and pushed a commit to address the review comments, except for
the doubles.
A proposal I have is:
* the old deprecated methods (from 4.0; getStreamThroughputMbPerSec and
getInterDCStreamThroughputMbPerSec) still should return int but we can throw
error message that they need either to use some of the other methods or to set
a whole number in megabits when the actual number internally is not an integer.
* make all new methods (both megabits and mibs) to return double plus printing
double in the setters as you pointed.
Does this sound reasonable and do you think I should confirm it on the mailing
list?
Also, further to the review comments I added the check for upper bound when
assigning the two old properties in the setters and added a unit test for that.
I also added a unit test for cache_load_timeout_seconds = -1.
> Add a flag for throughput in MiB/s for nodetool setstreamthroughput,
> getstreamthroughput, setinterdcstreamthroughput and
> getinterdcstreamthroughput
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17725
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17725
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.x
>
>
> As we agreed not to add new JMX methods for the new config on the mailing
> list, we need at least new flags for setstreamthroughput and
> interdcstreamthroughput for the two 4.0 parameters to be set/get also in MiB,
> not only in megabits.
> Thus we will have the option either to use the old version for those 2, or to
> be able to set/get in MiB all 4 streaming parameters. As of 4.1 supported
> units for DataRateSpec are MiB/s, B/s, KiB/s, megabit is only for legacy from
> 4.0 - backward compatibility.
> To be sure we satisfy the requirements around the latest discussions about
> backward compatibility in tools, I will use this ticket also to make a final
> pass on the unit changes done, to ensure the probe output is not affected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
