[
https://issues.apache.org/jira/browse/CASSANDRA-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569879#comment-17569879
]
Benedict Elliott Smith edited comment on CASSANDRA-17768 at 7/22/22 8:51 AM:
-----------------------------------------------------------------------------
I think it was always unused, since we specify keep alive at the TCP layer. Or,
potentially we did not at some point previously specify keep alive at the TCP
layer, but by the time of the refactor we certainly did.
was (Author: benedict):
I think it was always unused, since we specify keep alive at the TCP layer.
> streaming_keep_alive_period is not used after [CASSANDRA-16927] CEP-10 Phase
> 1: Refactor Streaming
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17768
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17768
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Streaming and Messaging
> Reporter: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.1-beta, 4.1.x, 4.x
>
>
> While working on another ticket I noticed that after [CASSANDRA-16927] CEP-10
> Phase 1: Refactor Streaming
> streaming_keep_alive_period is not used anymore, except to print it in error
> message
> [here|https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/streaming/StreamSession.java#L689]
> If the property should not be used anymore, we need to deprecate it and fix
> the error message as it is misleading.
> [~benedict] , [~samt] , [~aleksey] , can you, please, check and take care of
> this one as authors of that patch?
> Thank you in advance!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
